Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow using matches from externals for regex matching #825

Merged
merged 2 commits into from Dec 2, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 1, 2021

This allows using matches from regex externals to allow maintaining exact require paths without having to list every exact require in the externals config. This allows fixing a longstanding issue in Next.js with ensuring caniuse-lite data is externalized properly since autoprefixer uses exact requires which can be seen here. Related TODO in Next.js here.

This data being incorrectly bundled with ncc can be seen in this PR vercel/next.js#31984

@ijjk ijjk marked this pull request as ready for review December 1, 2021 19:56
@styfle styfle changed the title Allow using matches from externals for regex matching feat: Allow using matches from externals for regex matching Dec 2, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@styfle styfle enabled auto-merge (squash) December 2, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants