Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix source maps #818

Merged
merged 2 commits into from Dec 2, 2021
Merged

fix: Fix source maps #818

merged 2 commits into from Dec 2, 2021

Conversation

fenix20113
Copy link
Contributor

@fenix20113 fenix20113 commented Nov 22, 2021

  • Fix missing source map register if the v8 cache enabled
  • Fix missing source maps in assets if the v8 cache disabled

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

It would be great to add a test to show this fixes the intended bug 👍

* Fix missing source map register if the v8 cache enabled
* Fix missing source maps in assets if the v8 cache disabled
@fenix20113
Copy link
Contributor Author

Hi @styfle , I updated the PR with tests

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants