Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: package.json asset type module setting #733

Merged
merged 3 commits into from Jul 22, 2021
Merged

fix: package.json asset type module setting #733

merged 3 commits into from Jul 22, 2021

Conversation

guybedford
Copy link
Contributor

This fixes #732, which was a feature added to ensure any emitted package.json doesn't stop the "type": "module" boundary from applying, but had a typo in the reading process.

@guybedford guybedford mentioned this pull request Jul 22, 2021
Closed
styfle
styfle approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@styfle styfle enabled auto-merge (squash) July 22, 2021 17:17
@styfle styfle merged commit cd34f24 into main Jul 22, 2021
@styfle styfle deleted the fix-pjson-emission branch July 22, 2021 18:21
@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Awaiting requested review from Timer Timer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when building ESM project
2 participants
@guybedford @styfle