Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat compilation.errors as a set #705

Merged
merged 1 commit into from Apr 30, 2021
Merged

fix: treat compilation.errors as a set #705

merged 1 commit into from Apr 30, 2021

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Apr 30, 2021

I believe this will fix the deprecation warning in #704, by not assuming compilation.errors has array methods. Resolves #704.

@codecov-commenter
Copy link

Codecov Report

Merging #705 (3ff903e) into main (571eced) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files          13       13           
  Lines         476      476           
=======================================
  Hits          350      350           
  Misses        126      126           
Impacted Files Coverage Δ
src/index.js 79.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571eced...3ff903e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET warning
3 participants