Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle terser error #703

Merged
merged 3 commits into from Apr 29, 2021
Merged

fix: handle terser error #703

merged 3 commits into from Apr 29, 2021

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Apr 29, 2021

With the Terser upgrade in #669 the error handling needed to be updated to handle the new async form of the function.

As a result Terser errors were becoming build errors, which is fixed here.

This resolves the Terser error regression from #697.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle changed the title Fixup terser error handling fix: handle terser error Apr 29, 2021
@styfle styfle merged commit 571eced into main Apr 29, 2021
@styfle styfle deleted the terser-err branch April 29, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants