Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock license plugin version #692

Merged
merged 1 commit into from Apr 12, 2021
Merged

fix: lock license plugin version #692

merged 1 commit into from Apr 12, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 12, 2021

Resolves #686

temp workaround on require.resolve usage from deps

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like a downgrade (2.3.16 to 2.3.11) according to the lock file.

Is there an upstream issue we should be following?

@styfle styfle merged commit ad9d310 into vercel:master Apr 12, 2021
@huozhi huozhi deleted the lock-license-plugin branch April 13, 2021 01:47
@huozhi
Copy link
Member Author

huozhi commented Apr 13, 2021

The usage of using require.resolve on plugin side is introduced in versions >= 2.3.12, so I downgrade to 2.3.11. This unexpected upgration is introduced in #674. previously ncc is using 2.3.0. so I picked the latest patch version works for ncc (2.3.11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'webpack' upgrade from 0.28.0 to 0.28.1
3 participants