Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to terser@5.6.1 #669

Merged
merged 6 commits into from
Mar 21, 2021
Merged

Upgrade to terser@5.6.1 #669

merged 6 commits into from
Mar 21, 2021

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Mar 19, 2021 •
edited

This updates to terser@5.6.1 with latest syntax support.

Fixes #661.

@guybedford guybedford mentioned this pull request Mar 19, 2021
Closed
@styfle styfle added the automerge Automatically merge PR once checks pass label Mar 19, 2021
styfle
styfle reviewed Mar 19, 2021
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for console.log?.("hello")

@styfle styfle removed the automerge Automatically merge PR once checks pass label Mar 19, 2021
@styfle styfle added the automerge Automatically merge PR once checks pass label Mar 21, 2021
@kodiakhq kodiakhq bot merged commit c167a60 into master Mar 21, 2021
@kodiakhq kodiakhq bot deleted the terser-upgrade branch March 21, 2021 18:39
@Obi-Dann Obi-Dann mentioned this pull request Apr 10, 2021
Draft
@github-actions github-actions bot mentioned this pull request Apr 13, 2021
Merged
@guybedford guybedford mentioned this pull request Apr 29, 2021
Merged
styfle pushed a commit that referenced this pull request Apr 29, 2021
@guybedford
fix: handle terser error (#703)
571eced 
With the Terser upgrade in #669 the error handling needed to be updated to handle the new async form of the function.

As a result Terser errors were becoming build errors, which is fixed here.

This resolves the Terser error regression from #697.
musaevonline added a commit to musaevonline/react-animation-ncc that referenced this pull request Dec 4, 2021
@musaevonline
fix: handle terser error (#703)
058b9b7 
With the Terser upgrade in vercel/ncc#669 the error handling needed to be updated to handle the new async form of the function.

As a result Terser errors were becoming build errors, which is fixed here.

This resolves the Terser error regression from vercel/ncc#697.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minification failed
2 participants
@guybedford @styfle