"exports" conditions semantics #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
exports-nomodule
branch
2 times, most recently
from
8bb367e
to
ce63108
Compare
styfle
approved these changes
Mar 18, 2021
guybedford
force-pushed
the
exports-nomodule
branch
from
78b9474
to
01cba6b
Compare
styfle
reviewed
Mar 18, 2021
| @@ -52,8 +52,24 @@ function ncc ( | |||
| transpileOnly = false, | |||
| license = '', | |||
| target, | |||
| production = true, | |||
There was a problem hiding this comment.
Does node automatically consider 'production' exports?
There was a problem hiding this comment.
Seems like this should be conditions: string[] instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates ncc to follow the "node" condition and not the "module" condition in the exports field with tests.
This will ensure that the built semantics exactly mirror the Node.js semantics.
Support for the "imports" field similarly is pending webpack/webpack#12928.