Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing: ms with StringValue should not accept options #197

Open
meshuamam opened this issue Jun 5, 2023 · 1 comment
Open

Typing: ms with StringValue should not accept options #197

meshuamam opened this issue Jun 5, 2023 · 1 comment

Comments

@meshuamam
Copy link

Currently, the definition of ms in the typing is:

declare function ms(value: StringValue, options?: Options): number;
declare function ms(value: number, options?: Options): string;

the StringValue version should not accept options, since it doesn't use it
@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 16, 2023 •
edited

Great catch @meshuamam. Would you be interested in raising a PR with that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meshuamam @mrmckeb