Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Header Label #39

Merged
merged 4 commits into from Apr 14, 2022
Merged

Validate Header Label #39

merged 4 commits into from Apr 14, 2022

Conversation

shizhMSFT
Copy link
Contributor

Fix #38

@shizhMSFT
validate marshal
7baaf9e 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
validate unmarshal
2dd340b 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
pretty print label
eebe0f2 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
consistant variable naming
fa85182 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
qmuntal
qmuntal approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shizhMSFT shizhMSFT merged commit a6cd7ce into veraison:remote-signing Apr 14, 2022
@shizhMSFT shizhMSFT deleted the enforce_map_key branch April 14, 2022 11:12
@shizhMSFT shizhMSFT mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmuntal qmuntal qmuntal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shizhMSFT @qmuntal