Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Double click solution for external sources (iframes as well as embeddings) #345

Open
saschafoerster opened this issue Feb 8, 2022 · 8 comments

Comments

@saschafoerster
Copy link

I would be very happy if iFrames and Embeddings could only be loaded, when a double click solution was presented to inform the user, that external resources will be loaded. A very good implementation (but from Wordpress) is the plugin "Embed privacy":
https://de.wordpress.org/plugins/embed-privacy/

They hide the content with a banner, that is informative (and can be changed to show more details), it shows a link to the data protection informations and it has a button to allow this single external resource or all external ressources of the same kind.

Participants usually don't really know that external ressources are loaded and maybe data is transferred somewhere else, than they thought. Also there is no cookie banner yet, so organizers can only inform them when using a ticketing solution and informing there. But still it would be great to have the option to participate without getting YouTube-cookies for instance, when there is an embedding.

@rashfael
Copy link
Contributor

Hm, do we want to support one-time consent? As in "click to load iframe and on next visit it shows the blocker again"?

@raphaelm
Copy link
Member

Remembering it per room would be a big comfort win, why wouldn't we want that? Remembering per domain would be even nicer but probably raises issues because different rooms might have different banner texts even if they embed the same domain

@saschafoerster
Copy link
Author

I think one one-time-consent should be per room, but we also need one-time-consent for YouTube-embeddings, for instance in an expo-header, in the middle of some textpage, when we use embedded external ressources. This kind of consent could be domain-wise (do you want to allow YouTube.org, ... ) and then all videos from YouTube should work. :)

@rashfael
Copy link
Contributor

With "one-time" I mean the difference between "I am allowing this element and when I leave and come back I want the consent blocker to be shown again" vs "I am allowing this element and venueless will remember this". The second one is a more common expectation for "normal" users, but I'm pretty sure some overly privacy aware people will want the first one.

Consent-blocking arbitrary iframes or video elements inside pages is another can of worms entirely and much more complex to build because of all the ways those youtube iframes can land in there. (And don't get me started on iframes containing youtube videos themselves).

@raphaelm
Copy link
Member

The second one is a more common expectation for "normal" users, but I'm pretty sure some overly privacy aware people will want the first one.

As far as I am aware, it is perfectly fine to store that someone consented and not ask them every time, at least if the question is clearly phrased.

@saschafoerster
Copy link
Author

I like how the plugin "embed privacy" leaves the choice, if I want to consent just this time or get a cookie to save it for longer time OR just open the link in a full new window.
All the texts can be changed depending on the embedding-provider (YouTube, Twitter,...)
Bildschirmfoto 2022-02-28 um 16 33 03

@raphaelm
Copy link
Member

raphaelm commented Mar 3, 2022

I talked to our privacy lawyer about this. If we just have a "Yes" button, we are allowed to "remember" the agreement for the duration of a "session" (whatever that is, likely a browser session similar to a cookie without expiry date). If we give the user an explicit choice between a "Yes" button and and a "Yes, always" button like @saschafoerster suggestes, it's fine saving the agreement for a longer timeframe if the user clicks the latter button.

@rashfael
Copy link
Contributor

rashfael commented Mar 9, 2022

I had a look if I could build something that would intercept any iframe that's created anywhere in venueless, which kinda worked, but I could not prevent freshly created iframes from starting a network request to their src.
With a generic solution not being good enough, we have to add iframe handling to every source manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants