Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order has been paid and the status is paymentauthorized. Click Modify order, and the page does not jump to the edit page #1032

Closed
skyearthfeng opened this issue Aug 13, 2021 · 8 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@skyearthfeng
Copy link

Describe the bug
The order has been paid and the status is paymentauthorized. Click Modify order, and the page does not jump to the edit page
Browser development tool display error:
新建位图图像 (3)

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
the page does not jump to the edit page

Environment (please complete the following information):

  • @vendure/core version:10.2.2
  • Nodejs version:v12.22.1
  • Database (mysql/postgres etc):sqlite

Additional context
Add any other context about the problem here.

@skyearthfeng skyearthfeng added the type: bug 🐛 Something isn't working label Aug 13, 2021
skyearthfeng added a commit to skyearthfeng/vendure that referenced this issue Aug 17, 2021
@skyearthfeng
Copy link
Author

The problem has been found. Just modify it as follows:
1629190484(1)

@michaelbromley
Copy link
Member

Hi, I cannot reproduce this on the current latest version 1.1.3.

In your report you put the Vendure version as @vendure/core version:10.2.2. This is not a valid version - can you check again?

@skyearthfeng
Copy link
Author

Sorry, @ vendure / core version: 10.2.2, wrong. It should be @ vendure / core version: 1.1.3.

My browser is::
Microsoft Edge
版本 92.0.902.73 (官方内部版本) (64 位)

@skyearthfeng
Copy link
Author

The same problem is tested in chrome v92.0.4515.159 browser
新建位图图像 (5)

@michaelbromley
Copy link
Member

Ok. Looks like it could be related to apollographql/apollo-client#7608

Can you tell me the exact version of Apollo Client installed using npm ls @apollo/client?

@michaelbromley michaelbromley added this to Next release in Vendure Roadmap Aug 20, 2021
@skyearthfeng
Copy link
Author

"name": "@apollo/client",
"version": "3.3.11",
"description": "A fully-featured caching GraphQL client.",

@michaelbromley
Copy link
Member

Hi, sorry about the long delay on getting back on this. I have been doing some reading and it seems there can be memory leak issues with shareReplay:

The advice seemed conflicting on whether it is better to put the takeUntil before or after the shareReplay operator.

Could you try this change, and let me know if it also solves the issue?

    const stream = this.entityStream(id || '').pipe(
                takeUntil(navigateAway$),
                filter(notNullOrUndefined),
-               shareReplay(1),
+               shareReplay({ bufferSize: 1, refCount: true }),

@michaelbromley michaelbromley moved this from Next release to Awaiting Response in Vendure Roadmap Sep 23, 2021
@michaelbromley
Copy link
Member

I'm closing this issue because further data was needed but was not provided. If you want to continue the thread, let me know and I'll re-open it.

Vendure Roadmap automation moved this from Awaiting Response to Done Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants