Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe pointer #460

Merged
merged 2 commits into from May 5, 2022
Merged

Conversation

grongor
Copy link
Contributor

@grongor grongor commented Apr 26, 2022

Description

The issue seems valid, the provided solution seems correct, so...I just made the commits. 馃槅

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18

How Has This Been Tested?

Added test so the issue is reproducible.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

Merging #460 (989253d) into master (9f67b8a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   70.99%   71.06%   +0.06%     
==========================================
  Files           7        7              
  Lines        1293     1296       +3     
==========================================
+ Hits          918      921       +3     
  Misses        321      321              
  Partials       54       54              
Impacted Files Coverage 螖
pkg/generator.go 91.51% <100.00%> (+0.04%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9f67b8a...989253d. Read the comment docs.

@LandonTClipp LandonTClipp merged commit 1d92e73 into vektra:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocks don't correctly reference unsafe.Pointer
3 participants