Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump golang.org/x/tools to v0.1.10 to fix some go 1.18 issues #445

Merged

Conversation

MathiasGr
Copy link
Contributor

Description

Bump the golang.org/x/tools dependency to v0.1.10 to fix some issues during code gen.

Why bumping x/tools specifically? I got a hint from the ent/ent repo (see issue, PR) that had the exact same issue recently and fixed it by doing so.

Example running mockery with go 1.18 locally before the fix:

mockery <...>
config dir: <...>
config output:<...>
2022/04/11 20:11:11 internal error: package "context" without types was imported from "<...>"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

Merging #445 (aa25af0) into master (e8bf201) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   70.46%   70.46%           
=======================================
  Files           7        7           
  Lines        1263     1263           
=======================================
  Hits          890      890           
  Misses        320      320           
  Partials       53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8bf201...aa25af0. Read the comment docs.

golang.org/x/mod v0.5.1 h1:OJxoQ/rynoF0dcCdI7cLPktw/hR2cueqYfjm43oqK38=
golang.org/x/mod v0.5.1/go.mod h1:5OXOZSfqPIIbmVBIIKWRFfZjPR0E5r58TLhUjH0a2Ro=
golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 h1:kQgndtyPBW/JIYERgdxfwMYh3AVStj88WQTlNDi2a+o=
golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3/go.mod h1:3p9vT2HGsQu2K1YbXdKPJLVgG5VJdoTa1poYQBtP1AY=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use a dev version if possible, if we remove this is the original problem still resolved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! I think it's a transitive dependency so I can't really do much about it. See https://cs.opensource.google/go/x/tools/+/refs/tags/v0.1.10:go.mod

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see thanks, I will get this merged in a few hours.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks 🙏🏻 🤩

@hassansin
Copy link

Also got affected by this. Looking forward to the release. Thanks

@Lawrence-Dawson
Copy link

I'm also being impacted by this. Eagerly awaiting the release. Cheers

@LandonTClipp LandonTClipp merged commit 54589be into vektra:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants