New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump golang.org/x/tools to v0.1.10 to fix some go 1.18 issues #445
fix: bump golang.org/x/tools to v0.1.10 to fix some go 1.18 issues #445
Conversation
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 70.46% 70.46%
=======================================
Files 7 7
Lines 1263 1263
=======================================
Hits 890 890
Misses 320 320
Partials 53 53 Continue to review full report at Codecov.
|
golang.org/x/mod v0.5.1 h1:OJxoQ/rynoF0dcCdI7cLPktw/hR2cueqYfjm43oqK38= | ||
golang.org/x/mod v0.5.1/go.mod h1:5OXOZSfqPIIbmVBIIKWRFfZjPR0E5r58TLhUjH0a2Ro= | ||
golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 h1:kQgndtyPBW/JIYERgdxfwMYh3AVStj88WQTlNDi2a+o= | ||
golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3/go.mod h1:3p9vT2HGsQu2K1YbXdKPJLVgG5VJdoTa1poYQBtP1AY= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use a dev version if possible, if we remove this is the original problem still resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! I think it's a transitive dependency so I can't really do much about it. See https://cs.opensource.google/go/x/tools/+/refs/tags/v0.1.10:go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see thanks, I will get this merged in a few hours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks 🙏🏻 🤩
Also got affected by this. Looking forward to the release. Thanks |
I'm also being impacted by this. Eagerly awaiting the release. Cheers |
Description
Bump the golang.org/x/tools dependency to v0.1.10 to fix some issues during code gen.
Why bumping x/tools specifically? I got a hint from the ent/ent repo (see issue, PR) that had the exact same issue recently and fixed it by doing so.
Example running mockery with go 1.18 locally before the fix:
Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist