Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Go 1.18 and fix GetSemverInfo() #436

Merged
merged 2 commits into from Mar 30, 2022

Conversation

emmanuel099
Copy link
Contributor

@emmanuel099 emmanuel099 commented Mar 25, 2022

debug.ReadBuildInfo() changed its behavior since Go 1.18 which caused a test failure in TestGeneratorSuite/TestGeneratorPrologueNote.

@emmanuel099 emmanuel099 changed the title Test with Go 3.18 Test with Go 3.18 and fix GetSemverInfo() Mar 25, 2022
@markuspeloquin
Copy link

s/3.18/1.18/ :)

In Go 1.18 debug.ReadBuildInfo() may successfully return a build
info where the main version is empty. Return the default SemVer
in this case.
@emmanuel099 emmanuel099 changed the title Test with Go 3.18 and fix GetSemverInfo() Test with Go 1.18 and fix GetSemverInfo() Mar 28, 2022
@markuspeloquin
Copy link

@LandonTClipp This looks like it's blocking #435 and according to joe-rocko#1 it builds fine. Can we please get this merged? <3

@LandonTClipp
Copy link
Contributor

LandonTClipp commented Mar 29, 2022 via email

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #436 (fa0080c) into master (adda07f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   69.80%   69.80%           
=======================================
  Files           7        7           
  Lines        1262     1262           
=======================================
  Hits          881      881           
  Misses        333      333           
  Partials       48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adda07f...fa0080c. Read the comment docs.

@LandonTClipp LandonTClipp merged commit b11695e into vektra:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants