Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load packages with dependencies for Go 1.18 #435

Merged
merged 1 commit into from Mar 30, 2022

Conversation

emmanuel099
Copy link
Contributor

Without the additional NeedDeps mockery fails with:
"Unexpected package creation during export data loading"

Refs #434

Without the additional `NeedDeps` mockery fails with:
"Unexpected package creation during export data loading"

Refs vektra#434
@drshriveer
Copy link

❤️ please approve soon!

@atombender
Copy link
Contributor

@LandonTClipp Can we get this merged?

@LandonTClipp
Copy link
Contributor

Hi folks, I am looking into this right now and hope to get merged soon. Apologies for the delay, clearly this is desired by the community to fix!

@LandonTClipp
Copy link
Contributor

@emmanuel099 if you could update the github workflow so it includes golang 1.18 for tests (and possibly release as well) that would be great. Otherwise, I will get to it later this evening.

@emmanuel099
Copy link
Contributor Author

if you could update the github workflow so it includes golang 1.18 for test (and possibly release as well)

@LandonTClipp First part done, not sure about the second. Do you want me to change the minimum supported Golang version to 1.18? If so, I would open another PR.

@LandonTClipp
Copy link
Contributor

LandonTClipp commented Mar 24, 2022

Thanks the test itself is probably sufficient as we're not using any 1.18 features (yet). I will get it merged shortly.

Edit: the github workflow is for some reason stuck at "Queued". I can't seem to cancel it either. Assuming there is some issue the github team is working on, we'll wait for that to be resolved.

https://www.githubstatus.com/incidents/y5hdmv0p49x3

@emmanuel099
Copy link
Contributor Author

@LandonTClipp Hmm, the test failure seems to be unrelated. Fixed in #436

@LandonTClipp LandonTClipp merged commit 232f954 into vektra:master Mar 30, 2022
LandonTClipp added a commit that referenced this pull request Apr 5, 2022
This was introduced #435 but it wasn't the correct solution.
@alswl
Copy link

alswl commented May 23, 2022

It was my temporary solution, using go 1.17 to generate mockery types.

# install 1.17
brew install go@1.17

# load 1.17 env
alias loadgo117="export PATH=\"/usr/local/opt/go@1.17/bin:${PATH}\""
loadgoenv17
go version
# go version go1.17.10 darwin/amd64


go mod download
make generate-code-mockery  # it was my project's mockery command, please replace with your own mockery command

# don't forget reset your go.mod
zsh # reset your shell
go mod tidy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants