New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load packages with dependencies for Go 1.18 #435
Conversation
Without the additional `NeedDeps` mockery fails with: "Unexpected package creation during export data loading" Refs vektra#434
❤️ please approve soon! |
@LandonTClipp Can we get this merged? |
Hi folks, I am looking into this right now and hope to get merged soon. Apologies for the delay, clearly this is desired by the community to fix! |
@emmanuel099 if you could update the github workflow so it includes golang 1.18 for tests (and possibly release as well) that would be great. Otherwise, I will get to it later this evening. |
@LandonTClipp First part done, not sure about the second. Do you want me to change the minimum supported Golang version to 1.18? If so, I would open another PR. |
Thanks the test itself is probably sufficient as we're not using any 1.18 features (yet). I will get it merged shortly. Edit: the github workflow is for some reason stuck at "Queued". I can't seem to cancel it either. Assuming there is some issue the github team is working on, we'll wait for that to be resolved. |
@LandonTClipp Hmm, the test failure seems to be unrelated. Fixed in #436 |
This was introduced #435 but it wasn't the correct solution.
It was my temporary solution, using go 1.17 to generate mockery types.
|
Without the additional
NeedDeps
mockery fails with:"Unexpected package creation during export data loading"
Refs #434