Fix: avoid package name collision with inPackage (#291)

[i-sevostyanov]

Fixes #291.

Tired of waiting, so I copied everything from #402, sorry.

[fterrag]

Can we get this PR reviewed, please? Thanks!

[peppelan]

same here, would be great, thankyousomuchplease

[strideynet]

@LandonTClipp What's the status of this ? Any reason this isn't being moved forward with ?

[LandonTClipp]

@i-sevostyanov @strideynet sorry for the delay, life gets in the way sometimes, I'm trying to work through a backlog of stuff. Can you write in the description more succinctly what the solution to the original problem is? This is just to aid me so I can know better what I'm looking at.

[i-sevostyanov]

I think this issue describes the problem in detail: Invalid mock generated with the same package names 🤓

[serivkos]

@LandonTClipp I would appreciate if you could look over this request and merge it with master. I’ll be waiting for that. Thanks

[fterrag]

We're currently working around this with some sed magic - looking forward to a fix!

[LandonTClipp]

Thanks for the PR, just a few minor comments and we can get this merged.

[LandonTClipp]

Looks good!

[codecov-commenter]

Codecov Report

Merging #422 (facf60b) into master (58a7f18) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   70.72%   70.99%   +0.27%     
==========================================
  Files           7        7              
  Lines        1291     1293       +2     
==========================================
+ Hits          913      918       +5     
+ Misses        325      321       -4     
- Partials       53       54       +1     

Impacted Files	Coverage Δ
pkg/generator.go	91.47% <100.00%> (+0.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a7f18...facf60b. Read the comment docs.

[LandonTClipp]

@i-sevostyanov sorry one more thing :) the coverage report is showing some missing coverage.

https://app.codecov.io/gh/vektra/mockery/compare/422/changes

Could you add tests for the cases that are missing? PRs generally should be increasing coverage, as a matter of principle.

[i-sevostyanov]

Done 🤓