Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests from graphql-js #136

Open
vikstrous opened this issue Oct 22, 2020 · 2 comments
Open

update tests from graphql-js #136

vikstrous opened this issue Oct 22, 2020 · 2 comments

Comments

@vikstrous
Copy link
Contributor

Looks like the tests exported from the graphql-js repo are very out of date. I looked through the history of the graphql-js repo and it looks like the package.json in validator/imported/package.json file comes from https://github.com/graphql/graphql-js/blob/68577079930e24da9c25b6c3f8fcadd488d94014/package.json. Trying to update the tests with ./export.sh doesn't work any more. The first problem seems related to babel, but there might be a lot more broken things here. I'm curious to know how much the two repos have diverged, so I'd like to get these tests updated. Any tips would be appreciated.

@lwc
Copy link
Collaborator

lwc commented Oct 22, 2020

I think this branch is an attempt to do that too? I've not had the time to try it out though. If you've got some time to look at it, that would be amazing!

#112

@vvakame
Copy link
Collaborator

vvakame commented Apr 15, 2021

#112 was merged (thanks lwc!)

I tried to update our export harness first, but graphql-js harness interface is changed... 😿
so, I think we should be...

  1. update package.json and package-lock.json to newest babel version.
  2. reimplement our export harness. emit new yaml.
  3. suppress failed tests. its maybe cause by new GraphQL specs.

when this works done. We can update our implementations and un-suppress test step by step. I think.

my latest try
https://github.com/vvakame/gqlparser/commits/update-validations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants