{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":581272934,"defaultBranch":"main","name":"sapling","ownerLogin":"vegerot","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-12-22T18:23:41.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5297725?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1696268948.0","currentOid":""},"activityList":{"items":[{"before":"47c8f223f24ef5359cb9216051522e23fa70130a","after":"bfd91e4a93a2ed6c0f79cd80fd88bfb6e7013285","ref":"refs/heads/main","pushedAt":"2024-04-14T22:00:04.000Z","pushType":"push","commitsCount":2693,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Apply clang-format 18\n\nSummary: Previously this code conformed from clang-format 12.\n\nReviewed By: igorsugak\n\nDifferential Revision: D56065247\n\nfbshipit-source-id: f5a985dd8f8b84f2f9e1818b3719b43c5a1b05b3","shortMessageHtmlLink":"Apply clang-format 18"}},{"before":"3ce839fbc0ff595b5ad5abd4245934632f639dbe","after":"47c8f223f24ef5359cb9216051522e23fa70130a","ref":"refs/heads/main","pushedAt":"2023-12-02T23:01:20.000Z","pushType":"push","commitsCount":1508,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"update platform010 & platform010-aarch64 symlinks\n\nSummary:\nRelease notes: https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html\n\nThis release is coupled with an update of the `anyhow` and `thiserror` crates because the unstable standard library API for backtraces has changed.\n\nFbcode changes:\n\n- `feature(default_free_fn)` deleted (D50300881)\n- `noop_method_call` lint becomes warn-by-default (D50486032, D50516201)\n- stronger `invalid_reference_casting` detection (D50488164)\n- `feature(unix_chown)` has been stabilized\n- `feature(provide_any)` and `std::provider` deleted\n- `clippy::unwrap_or_else_default` renamed to `clippy::unwrap_or_default`\n- type inference ambiguities (D51780425)\n- `nu-command` build error (D51779062)\n\nReviewed By: AndreasBackx, shayne-fletcher\n\nDifferential Revision: D50294321\n\nfbshipit-source-id: 0fac87f6ba072ad029f9ce41ce94ed813e855b20","shortMessageHtmlLink":"update platform010 & platform010-aarch64 symlinks"}},{"before":"85fc38543165d9fa9dda07ac2c594037a7b8c59c","after":"d639ad4398e83e845fc387386638a5b5649acad5","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-10-02T17:59:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge fb797bd0e92c7f9b59c50fe7b2e68d95a1aa8d19 into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge fb797bd into sapling-pr-archive-vegerot"}},{"before":"9fc34f03a5b9d3c8e8d70d94a5dcbf0f47d8634f","after":"fb797bd0e92c7f9b59c50fe7b2e68d95a1aa8d19","ref":"refs/heads/pr741","pushedAt":"2023-10-02T17:59:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"fix(build): correctly set target-specific variable values\n\nSummary:\nPreviously, the `HGNAME` and `OSS` variables were not being set correctly when\nbuilding with `make oss`. In my version of GNU Make on Ubuntu 22.04:\n```\nGNU Make 4.3\nBuilt for x86_64-pc-linux-gnu\n```\ninstead of the `OSS` variable being set to `true` and `HGNAME` being set to\n`sl`, the `OSS` variable was being set to `true HGNAME=sl`. This was causing\nthe eden binary to be built with the default `HGNAME` value of `hg`.\n\nHere is a minimal example of the issue:\n\n```makefile\nHG_NAME = hg\noss: OSS=true HG_NAME=sl\noss: local\n\nlocal:\n\t@echo \"OSS is $(OSS)\"\n\t@echo \"Building for $(HG_NAME)\"\n```\n\nOn my machine `make oss` prints\n\n```\nOSS is true HG_NAME=sl\nBuilding for hg\n```\n\nHowever,\n\n```makefile\nHG_NAME = hg\noss: OSS=true\noss: HG_NAME=sl\noss: local\n\nlocal:\n\t@echo \"OSS is $(OSS)\"\n\t@echo \"Building for $(HG_NAME)\"\n```\n\nprints\n\n```\nOSS is true\nBuilding for sl\n```\n\nTest Plan:\n1. On Ubuntu 22.04 and GNU Make 4.3, build sapling with `make oss`\n2. should see an error like\n\n```bash\nrunning build_mo\nrm -f hg\ncp build/scripts-3*/hg hg\ncp: cannot stat 'build/scripts-3*/hg': No such file or directory\nmake: *** [Makefile:85: local] Error 1\n```\n\n3. apply this patch and repeat step 1\n4. `sl` should build successfully","shortMessageHtmlLink":"fix(build): correctly set target-specific variable values"}},{"before":"04ac9bd458b8eca9514238bd45cc566c93558a62","after":"85fc38543165d9fa9dda07ac2c594037a7b8c59c","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-10-02T17:57:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge 9fc34f03a5b9d3c8e8d70d94a5dcbf0f47d8634f into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge 9fc34f0 into sapling-pr-archive-vegerot"}},{"before":"fceba8acd15a06478a6b6f51b4d57fdecde1a9ad","after":"9fc34f03a5b9d3c8e8d70d94a5dcbf0f47d8634f","ref":"refs/heads/pr741","pushedAt":"2023-10-02T17:57:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"fix(build): correctly set target-specific variable values\n\nSummary:\nPreviously, the `HGNAME` and `OSS` variables were not being set correctly when\nbuilding with `make oss`. In my version of GNU Make on Ubuntu 22.04:\n```\nGNU Make 4.3\nBuilt for x86_64-pc-linux-gnu\n```\ninstead of the `OSS` variable being set to `true` and `HGNAME` being set to\n`sl`, the `OSS` variable was being set to `true HGNAME=sl`. This was causing\nthe eden binary to be built with the default `HGNAME` value of `hg`.\n\nHere is a minimal example of the issue:\n\n```makefile\nHG_NAME = hg\noss: OSS=true HG_NAME=sl\noss: local\n\nlocal:\n\t@echo \"OSS is $(OSS)\"\n\t@echo \"Building for $(HG_NAME)\"\n```\n\nOn my machine `make oss` prints\n\n```\nOSS is true HG_NAME=sl\nBuilding for hg\n```\n\nHowever,\n\n```makefile\nHG_NAME = hg\noss: OSS=true\noss: HG_NAME=sl\noss: local\n\nlocal:\n\t@echo \"Building for $(HG_NAME)\"\n```\n\nprints\n\n```\nBuilding for sl\n```\n\nTest Plan:\n1. On Ubuntu 22.04 and GNU Make 4.3, build sapling with `make oss`\n2. should see an error like\n\n```bash\nrunning build_mo\nrm -f hg\ncp build/scripts-3*/hg hg\ncp: cannot stat 'build/scripts-3*/hg': No such file or directory\nmake: *** [Makefile:85: local] Error 1\n```\n\n3. apply this patch and repeat step 1\n4. `sl` should build successfully","shortMessageHtmlLink":"fix(build): correctly set target-specific variable values"}},{"before":"60df4b09476e64b35b7c3c054d2d9c8c7ebba00e","after":"04ac9bd458b8eca9514238bd45cc566c93558a62","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-10-02T17:49:11.000Z","pushType":"push","commitsCount":796,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge fceba8acd15a06478a6b6f51b4d57fdecde1a9ad into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge fceba8a into sapling-pr-archive-vegerot"}},{"before":null,"after":"fceba8acd15a06478a6b6f51b4d57fdecde1a9ad","ref":"refs/heads/pr741","pushedAt":"2023-10-02T17:49:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"fix(build): correctly set target-specific variable values\n\nSummary:\nPreviously, the `HGNAME` and `OSS` variables were not being set correctly when\nbuilding with `make oss`. In my version of GNU Make on Ubuntu 22.04:\n```\nGNU Make 4.3\nBuilt for x86_64-pc-linux-gnu\n```\ninstead of the `OSS` variable being set to `true` and `HGNAME` being set to\n`sl`, the `OSS` variable was being set to `true HGNAME=sl`. This was causing\nthe eden binary to be built with the default `HGNAME` value of `hg`.\n\nHere is a minimal example of the issue:\n\n```makefile\nHG_NAME = hg\noss: OSS=true HG_NAME=sl\noss: local\n\nlocal:\n\t@echo \"OSS is $(OSS)\"\n\t@echo \"Building for $(HG_NAME)\"\n```\n\nOn my machine this prints\n\n```\nOSS is true HG_NAME=sl\nBuilding for hg\n```\n\nHowever,\n\n```makefile\nHG_NAME = hg\noss: OSS=true\noss: HG_NAME=sl\noss: local\n\nlocal:\n\t@echo \"Building for $(HG_NAME)\"\n```\n\nprints\n\n```\nBuilding for sl\n```\n\nTest Plan:\n1. On Ubuntu 22.04 and GNU Make 4.3, build sapling with `make oss`\n2. should see an error like\n\n```bash\nrunning build_mo\nrm -f hg\ncp build/scripts-3*/hg hg\ncp: cannot stat 'build/scripts-3*/hg': No such file or directory\nmake: *** [Makefile:85: local] Error 1\n```\n\n3. apply this patch and repeat step 1\n4. `sl` should build successfully","shortMessageHtmlLink":"fix(build): correctly set target-specific variable values"}},{"before":"21ca46788076e8df199f6e1d4d1073745c5bb602","after":"3ce839fbc0ff595b5ad5abd4245934632f639dbe","ref":"refs/heads/main","pushedAt":"2023-10-02T17:48:55.000Z","pushType":"push","commitsCount":751,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"config: show invalid/dropped config values\n\nSummary:\nIf config values aren't in configs.allowedconfigs and their containing file isn't in configs.allowedlocations, we drop the config values. Previously there was no way to see them using \"sl config\", but now they will show up with an \"(invalid - dropped)\" source.\n\nWe achieve this by not actually deleting the config values. If the values are before the active value, we leave them since they will have no effect. If they are after the config value, we scooch them before the active value so they have no effect. If there is no active value, we append a dummy \"unset\" value so we can keep the invalid values.\n\nReviewed By: quark-zju\n\nDifferential Revision: D49274810\n\nfbshipit-source-id: c2b078718b7bdebec825dc4c382e2b7f8c962988","shortMessageHtmlLink":"config: show invalid/dropped config values"}},{"before":"036928027124c8af05938e2217504358bd32718c","after":"21ca46788076e8df199f6e1d4d1073745c5bb602","ref":"refs/heads/main","pushedAt":"2023-08-27T02:00:54.000Z","pushType":"push","commitsCount":43,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/wangle/commit/f9179d55e5241c40bc060897675eb11ea0dcd7be\n\nReviewed By: jailby\n\nfbshipit-source-id: 013ac2805db9bc8163f43f85d9dc38b6f76724f5","shortMessageHtmlLink":"Updating submodules"}},{"before":"eddfdf7355d3451c6ea30d91f7f4aadcdfc408e4","after":"60df4b09476e64b35b7c3c054d2d9c8c7ebba00e","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-08-25T04:51:17.000Z","pushType":"push","commitsCount":2291,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"merge commit for archive created by Sapling","shortMessageHtmlLink":"merge commit for archive created by Sapling"}},{"before":null,"after":"d8d3f46fdf9c79a7d53fa3d5e252b9f3a10fddf4","ref":"refs/heads/pr712","pushedAt":"2023-08-25T04:51:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"fix(build): fix version number when building with old Sapling\n\nSummary:\nFix a bug (#711) in Sapling that causes `sl --version` to not work when\nbuilding Sapling with an old version of Sapling.\n\nThe way `setup.py` gets the version number is by first **finding the path to\nthe vc exe** (`findhg`) and then running the `sl log ...` (or `git show ...`). `findhg`\ninterprets the `hint[old-version]` as an error and aborts.\n\nThis commit fixes the bug by simply adding `hint[old-version]` to `filterhgerr`\n\nTest Plan:\nIt doesn't seem straightforward to write an automated test for this since we\ndon't have tests for `setup.py`. The manual steps to test would be:\n\n1. get an old `sl`\n```sh\n$ sl go \"bsearch(date('-50'),main)\"\n```\n - verify it's old by running any `sl` command and make sure you get\n `hint[old-version]: WARNING! ...`\n2. build Sapling (`make oss`)\n3. `./sl --version`\n\nBefore this commit:\n\n```sh\n$ sl --version\nSaping 4.4.2\n```\n\nThis commit:\n```sh\n$ sl --version\nSapling \n```\n\nCloses #711","shortMessageHtmlLink":"fix(build): fix version number when building with old Sapling"}},{"before":"62bfe6af30088cead0e56d3412a7b6584d0ea84f","after":"036928027124c8af05938e2217504358bd32718c","ref":"refs/heads/main","pushedAt":"2023-08-25T04:18:14.000Z","pushType":"push","commitsCount":995,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/fbthrift/commit/649d0e1793068fb028fd1dae0a5b6e7185264b33\nhttps://github.com/facebook/proxygen/commit/c879e9412ed1dc914dbdcc5a9d88f8e46a1c2620\nhttps://github.com/facebook/rocksdb/commit/6353c6e2fbac3c982dd93e7be9208fed27107803\nhttps://github.com/facebookincubator/velox/commit/a90bf3b28687d317481c0ab3a9cc72972e16afa9\n\nReviewed By: jailby\n\nfbshipit-source-id: 5b8daad1a2631a217596c1691cebf9f42386bab3","shortMessageHtmlLink":"Updating submodules"}},{"before":"7baf69fa2088e4fc8c48cc37598d598d7b0bb481","after":"62bfe6af30088cead0e56d3412a7b6584d0ea84f","ref":"refs/heads/main","pushedAt":"2023-07-05T19:48:01.000Z","pushType":"push","commitsCount":481,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/ocamlrep/commit/716147d11fdf1489177a815ee5a47e9aae15cbc5\nhttps://github.com/facebook/watchman/commit/a90c50a491287686010f2e61f4b43406455b57c8\nhttps://github.com/facebookexperimental/rust-shed/commit/2214f5e2155424704a44e43d979de79eae69a1ab\nhttps://github.com/facebookincubator/superconsole/commit/3febddf45fa2959a0c23f782d67981d0efafecc3\n\nReviewed By: jurajh-fb\n\nfbshipit-source-id: 12e684938d2cd575e9c99af8c43c9fc3138305ec","shortMessageHtmlLink":"Updating submodules"}},{"before":"62e725e2ba129d17a9626d24bf1c41b28f4cc93b","after":"7baf69fa2088e4fc8c48cc37598d598d7b0bb481","ref":"refs/heads/main","pushedAt":"2023-06-01T17:09:43.153Z","pushType":"push","commitsCount":380,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/folly/commit/44fff7c3e49f040e18590926e0c831cf9eeddddd\nhttps://github.com/facebook/mcrouter/commit/82c13cdea73cb2358894704462615e619b4bd41a\nhttps://github.com/facebook/ocamlrep/commit/fcdc6fdf6fd587a4d82c962dc529b2aecfc5aeff\nhttps://github.com/facebook/wangle/commit/48c498debfb668100507c4a20aa52c090ad31287\nhttps://github.com/facebookexperimental/edencommon/commit/933339454cde7e35982401a5446c405cdb15ae75\nhttps://github.com/facebookincubator/fizz/commit/596a5276cb92b9c834c04ca1c1edda6afacd1339\nhttps://github.com/facebookincubator/katran/commit/10a58cb3c2d5d7579fb1baf5be4e59b535df5f21\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 498c6dbad79f0ff320d74389003fc20c9ead4c81","shortMessageHtmlLink":"Updating submodules"}},{"before":"0515fb7d2e5fd97df4afc4bd1f48006f3caa59ba","after":"62e725e2ba129d17a9626d24bf1c41b28f4cc93b","ref":"refs/heads/main","pushedAt":"2023-05-09T18:05:26.000Z","pushType":"push","commitsCount":433,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/fb303/commit/8ee480e9e7bdef537cfc39b0c34c97d413256648\nhttps://github.com/facebook/fbthrift/commit/1efe5a422da9dc268daaaf8e1761008a98f04274\nhttps://github.com/facebook/folly/commit/da785781e245ac8134f1343b8b26aa9f2aa864d2\nhttps://github.com/facebook/ocamlrep/commit/15064b38e360e4924c6ecc6a5f139689e3aee0d2\nhttps://github.com/facebook/proxygen/commit/71726eebc95bf5b4bfd19339e8b4a4ce3ee699cd\nhttps://github.com/facebook/wangle/commit/2320e61e0ceb91d4d9fd7b84a7445284c9262b5d\nhttps://github.com/facebook/watchman/commit/5f2e45bb67028181b10356906cdfd44e752ddc4b\nhttps://github.com/facebookexperimental/edencommon/commit/1cd66fede04626ea472cf653b078f55e439ffe92\nhttps://github.com/facebookincubator/fizz/commit/f9ba88ff979a7f211f8386a751ba9642a9302d0b\nhttps://github.com/facebookincubator/katran/commit/caf2b9f714e146cdf580f70c341d39efdfffb6e9\nhttps://github.com/facebookincubator/mvfst/commit/26a0723fe852620e876b99050027d13f06347237\nhttps://github.com/facebookincubator/velox/commit/db2e2786d942a53961165e2cd9b8cc4e00ef454d\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: ad50a17826398dff66017dd533e49a63e5726776","shortMessageHtmlLink":"Updating submodules"}},{"before":"94c239202d86193181fab005c9ff2e443754bd22","after":"eddfdf7355d3451c6ea30d91f7f4aadcdfc408e4","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-04-24T18:05:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge 405190f9c48de87a55f42c4f6cde4979c812542d into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge 405190f into sapling-pr-archive-vegerot"}},{"before":"a6b1ed66ea2eb1c56eb3f90a41483c03e50228a1","after":"405190f9c48de87a55f42c4f6cde4979c812542d","ref":"refs/heads/pr607","pushedAt":"2023-04-24T18:05:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"✨(clone): set publicheads to remote HEAD when cloning\n\nSummary:\nc8b66c68991066b3e added support for cloning the remote git repo's HEAD (in this\ncase `develop`), instead of main/master by default.\n\nHowever, this doesn't mark `remote/develop` and its ancestors as public\ncommits.\n\nThis commit will also set remote git repo's HEAD as a public commit\n\nCloses #600\n\nPull Request resolved: #607\n\nTest Plan:\n- Added test `test-git-clone-sets-publicheads.t`","shortMessageHtmlLink":"✨(clone): set publicheads to remote HEAD when cloning"}},{"before":"d4b6a00b98aefb5f7df0548d103aaa9f11ca082d","after":"94c239202d86193181fab005c9ff2e443754bd22","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-04-24T17:15:47.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge a6b1ed66ea2eb1c56eb3f90a41483c03e50228a1 into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge a6b1ed6 into sapling-pr-archive-vegerot"}},{"before":"eaa7efefb3ede0dc0a4933ed64443aa902bf89a2","after":"a6b1ed66ea2eb1c56eb3f90a41483c03e50228a1","ref":"refs/heads/pr607","pushedAt":"2023-04-24T17:15:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"✨(clone): set publicheads to remote HEAD when cloning\n\nSummary:\nc8b66c68991066b3e added support for cloning the remote git repo's HEAD (in this\ncase `develop`), instead of main/master by default.\n\nHowever, this doesn't mark `remote/develop` and its ancestors as public\ncommits.\n\nThis commit will also set remote git repo's HEAD as a public commit\n\nCloses #600\n\nPull Request resolved: #607\n\nTest Plan:\n- Added test `test-git-clone-sets-publicheads.t`","shortMessageHtmlLink":"✨(clone): set publicheads to remote HEAD when cloning"}},{"before":"f47fca53744ca7af7d8104d04b8274a1d41463fe","after":"0515fb7d2e5fd97df4afc4bd1f48006f3caa59ba","ref":"refs/heads/main","pushedAt":"2023-04-24T17:14:55.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"nodeipc: fix compatibility with chg\n\nSummary:\nFor chg, it needs to pass the node channel fd explicitly.\nThe chg server should not use the node channel fd, and should close it.\n\nTest script:\n\n # p.js\n const {spawn} = require('child_process');\n let executable = '/bin/hg';\n const args = ['dbsh', '-c', String.raw`b.nodeipc.IPC.send('foo'); ui.write(\"[Child] Got message: %r\\n\" % b.nodeipc.IPC.recv());`];\n const child = spawn(executable, args, {stdio: ['inherit', 'inherit', 'inherit', 'ipc']} );\n const responses = ['HELLO FROM PARENT 1', 'HELLO FROM PARENT 2', 'BYE'];\n child.on('message', message => {\n console.log('[Parent] Got message from child:', message);\n const response = responses.shift();\n if (response) { child.send(response); }\n });\n child.on('exit', () => { console.log('[Parent] Child process has exited'); });\n\nBefore:\n\n $ CHGSOCKNAME=$PWD/foo CHGDEBUG=1 node p.js\n using chg: true, because /etc/mercurial/usechg\n chg: debug: 0.000028 try connect to /home/quark/hg/lib/util/nodeipc/examples/foo-hg\n chg: debug: 0.000141 connected to foo-hg\n ...\n chg: debug: 0.007911 request runcommand, block size 96\n Traceback (most recent call last):\n File \"/opt/fb/mercurial/edenscm/ext/debugshell.py\", line 99, in debugshell\n exec(command, env, env)\n # command = 'b.nodeipc.IPC.send(\\'foo\\'); ui.write(\"[Child] Got message: %r\\\\n\" % b.nodeipc.IPC.recv());'\n File \"\", line 1, in \n BrokenPipeError: [Errno 32] Broken pipe (os error 32)\n chg: debug: 0.162147 response read from channel r, size 4\n chg: debug: 0.162160 got exitcode 255\n chg: debug: 0.162181 free context buffer\n [Parent] Child process has exited\n\nAfter:\n\n $ CHGSOCKNAME=$PWD/foo CHGDEBUG=1 HG_REAL_BIN=~/hg/hg node p.js\n using chg: true, because unix\n chg: debug: 0.000026 try connect to /home/quark/hg/lib/util/nodeipc/examples/foo-hg\n ...\n chg: debug: 0.008299 request attachio\n chg: debug: 0.008572 passing NODE_CHANNEL_FD 3\n chg: debug: 0.008870 response read from channel r, size 4\n ...\n chg: debug: 0.009038 request runcommand, block size 96\n [Parent] Got message from child: foo\n [Child] Got message: 'HELLO FROM PARENT 1'\n chg: debug: 0.163058 response read from channel r, size 4\n chg: debug: 0.163072 got exitcode 0\n chg: debug: 0.163084 free context buffer\n [Parent] Child process has exited\n\nReviewed By: zzl0\n\nDifferential Revision: D45011055\n\nfbshipit-source-id: 20d59358a5203f0966b13120ee8a5e1e8585adc3","shortMessageHtmlLink":"nodeipc: fix compatibility with chg"}},{"before":"bedc3545aef0a7db55b90674d892e6a237e8d763","after":"d4b6a00b98aefb5f7df0548d103aaa9f11ca082d","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-04-22T21:48:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"merge commit for archive created by Sapling","shortMessageHtmlLink":"merge commit for archive created by Sapling"}},{"before":"72a71fe3815bb38bf80c032d7d25de7b1f402e00","after":"eaa7efefb3ede0dc0a4933ed64443aa902bf89a2","ref":"refs/heads/pr607","pushedAt":"2023-04-22T21:48:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"✨(clone): set publicheads to remote HEAD when cloning\n\nSummary:\nc8b66c68991066b3e added support for cloning the remote git repo's HEAD (in this\ncase `develop`), instead of main/master by default.\n\nHowever, this doesn't mark `remote/develop` and its ancestors as public\ncommits.\n\nThis commit will also set remote git repo's HEAD as a public commit\n\nCloses #600\n\nPull Request resolved: #607\n\nTest Plan:\n- Added test `test-git-clone-sets-publicheads.t`","shortMessageHtmlLink":"✨(clone): set publicheads to remote HEAD when cloning"}},{"before":"296fc8c64acb9babe5faa5307d316c27ac166891","after":"bedc3545aef0a7db55b90674d892e6a237e8d763","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-04-22T21:08:33.000Z","pushType":"push","commitsCount":133,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"merge commit for archive created by Sapling","shortMessageHtmlLink":"merge commit for archive created by Sapling"}},{"before":"e36fa6be8afa3e45d4940415cfa3c9add7ae398a","after":"72a71fe3815bb38bf80c032d7d25de7b1f402e00","ref":"refs/heads/pr607","pushedAt":"2023-04-22T21:08:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"✨(clone): set publicheads to remote HEAD when cloning\n\nSummary:\nc8b66c68991066b3e added support for cloning the remote git repo's HEAD (in this\ncase `develop`), instead of main/master by default.\n\nHowever, this doesn't mark `remote/develop` and its ancestors as public\ncommits.\n\nThis commit will also set remote git repo's HEAD as a public commit\n\nCloses #600\n\nPull Request resolved: #607\n\nTest Plan:\n- Added test `test-git-clone-sets-publicheads.t`","shortMessageHtmlLink":"✨(clone): set publicheads to remote HEAD when cloning"}},{"before":"d97d51ef32cf81f7cd1ded8860487acba819b2dc","after":"f47fca53744ca7af7d8104d04b8274a1d41463fe","ref":"refs/heads/main","pushedAt":"2023-04-22T20:30:42.000Z","pushType":"push","commitsCount":131,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/fb303/commit/a28ec399b8785c8ac77eede5f056fa69f39d9304\nhttps://github.com/facebook/wangle/commit/8365d3bfa9a818e19323ec857e379b1e76a2ce75\nhttps://github.com/facebookexperimental/edencommon/commit/f291be1643cb21a97b28d60f591cc436950ab455\nhttps://github.com/facebookincubator/fizz/commit/d7bcaa8d7272ba152d80e2ce5e0dd1f3a030995c\nhttps://github.com/facebookincubator/katran/commit/115618a61480d5d4107c015cc47ec248ddb8f556\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 2fad1854609bee4bda5787f5a464ace328ccdd5d","shortMessageHtmlLink":"Updating submodules"}},{"before":"5e97610ff4841e82c777e27b68eba7718ae25e97","after":"296fc8c64acb9babe5faa5307d316c27ac166891","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-04-18T04:13:25.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge e36fa6be8afa3e45d4940415cfa3c9add7ae398a into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge e36fa6b into sapling-pr-archive-vegerot"}},{"before":"91ffca3ee939652b5914f7baf2fd0083dcdcad6a","after":"e36fa6be8afa3e45d4940415cfa3c9add7ae398a","ref":"refs/heads/pr607","pushedAt":"2023-04-18T04:13:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"✨(clone): set publicheads to remote HEAD when cloning\n\nSummary:\nc8b66c68991066b3e added support for cloning the remote git repo's HEAD (in this\ncase `develop`), instead of main/master by default.\n\nHowever, this doesn't mark `remote/develop` and its ancestors as public\ncommits.\n\nThis commit will also set remote git repo's HEAD as a public commit\n\nCloses #600\n\nPull Request resolved: #607\n\nTest Plan:\n- Added test `test-git-clone-sets-publicheads.t`","shortMessageHtmlLink":"✨(clone): set publicheads to remote HEAD when cloning"}},{"before":"9b1da2c3170a3930da3318cf1db16946f0638d90","after":"d97d51ef32cf81f7cd1ded8860487acba819b2dc","ref":"refs/heads/main","pushedAt":"2023-04-18T04:13:19.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/cachelib/commit/16d92c2c72094434a87e5456a5715ccb4c360666\nhttps://github.com/facebook/fb303/commit/c8b2240e93da1e3d2df4aaaaa7ae384f4d21cf47\nhttps://github.com/facebook/watchman/commit/1d362c2905dfe38b516223c6f37cda85c5ca1cad\nhttps://github.com/facebookincubator/velox/commit/41b05db6492060f12cb17fb9d406748b7f0d2ae3\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: c1d483548d44487f211193fea5a7bb23341b213b","shortMessageHtmlLink":"Updating submodules"}},{"before":"41f6e253c2e63134179f03a2cd9ef2b7215fc3f7","after":"5e97610ff4841e82c777e27b68eba7718ae25e97","ref":"refs/heads/sapling-pr-archive-vegerot","pushedAt":"2023-04-18T04:12:12.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"vegerot","name":"Max Coplan","path":"/vegerot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5297725?s=80&v=4"},"commit":{"message":"Merge 91ffca3ee939652b5914f7baf2fd0083dcdcad6a into sapling-pr-archive-vegerot","shortMessageHtmlLink":"Merge 91ffca3 into sapling-pr-archive-vegerot"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEMF-qrQA","startCursor":null,"endCursor":null}},"title":"Activity · vegerot/sapling"}