Panic when field name includes a :

[boydgreenfield]

When a field name includes a :, vegafusion cannot handle it and raises a PanicException. Here's a minimal example for which the spec works fine in the Vega Editor:

import vegafusion as vf
import vl_convert as vlc

spec = {
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {"values": [        
        {"Horsepower:": 225, "Miles_per_Gallon": 14, "Origin": "USA"},
        {"Horsepower:": 95, "Miles_per_Gallon": 24, "Origin": "Japan"},
        {"Horsepower:": 95, "Miles_per_Gallon": 22, "Origin": "USA"},
        {"Horsepower:": 97, "Miles_per_Gallon": 18, "Origin": "USA"},
      ]},
  "mark": "point",
  "encoding": {
    "x": {"field": "Horsepower:", "type": "quantitative"},
    "y": {"field": "Miles_per_Gallon", "type": "quantitative"},
    "color": {"field": "Origin", "type": "nominal"},
  }
}


vlc.vegalite_to_vega(spec)  # works
vf.runtime.build_pre_transform_spec_plan(vlc.vegalite_to_vega(spec))  # raises PanicException

[jonmmease]

Can confirm that this panics in VegaFusion and works in Vega-Lite. Thanks for the report!

[jonmmease]

Is this blocking for you right now @boydgreenfield?

[boydgreenfield]

Is this blocking for you right now @boydgreenfield?

We have an open issue tracking it @jonmmease, but I've only seen it "in the wild" once so far. Note @Keats and I are working on this together and he may have some findings/detail to report in the AM.

[jonmmease]

Ok, thanks for the context. I'll get to it over the next couple of weeks. I think the check itself can just be removed, but I need to dig into why I added it in the first place.

[Keats]

Yeah that's what I did as well on my branch https://github.com/Keats/vegafusion but I was digging in the various libraries to see why it was there

[jonmmease]

Could you open a PR with that change @Keats? I'll dig into whether there are any downstream implications of it when I review it. Thanks!

BTW, I'm a big fan of Zola and use it for my personal website!