Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path parser crashes on small line distances on v5.22 #3451

Closed
dnlbln opened this issue Mar 24, 2022 · 1 comment
Closed

Path parser crashes on small line distances on v5.22 #3451

dnlbln opened this issue Mar 24, 2022 · 1 comment
Labels
bug For bugs or other software errors

Comments

@dnlbln
Copy link

dnlbln commented Mar 24, 2022

Path parser has been rewritten in 5.22 and it causes a bug in a specific test case of our arrow charts. Click on the screenshot below to see the full resolution and you will have a good overview of the bug.

test

The offending code can be found on line 10 here: 63abce9

line 10, the code that crashes: path.match(commandPattern). I don't have complete insight in the vega codebase as this is my first time looking into it, but since .match can return null I am pretty confident that regardless the case that there should be a null check there.

I tested it myself and adding a null check will give the exact same result as in 5.21.

@dnlbln dnlbln added the bug For bugs or other software errors label Mar 24, 2022
@jheer
Copy link
Member

jheer commented Mar 25, 2022

Thanks! Added null check for v5.22.1.

@jheer jheer closed this as completed Mar 25, 2022
@jheer jheer mentioned this issue Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For bugs or other software errors
Projects
None yet
Development

No branches or pull requests

2 participants