Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat spec with shared encoding does not replace repeat #8734

Open
domoritz opened this issue Feb 20, 2023 · 2 comments · May be fixed by #9246
Open

Repeat spec with shared encoding does not replace repeat #8734

domoritz opened this issue Feb 20, 2023 · 2 comments · May be fixed by #9246
Labels
Bug 🐛 P2 Important Issues that should be fixed soon

Comments

@domoritz
Copy link
Member

In

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {"url": "data/movies.json"},
  "repeat": {"column": ["US Gross", "Worldwide Gross"]},
  "spec": {
    "encoding": {
      "x": {"bin": true, "field": "IMDB Rating", "type": "quantitative"},
      "y": {
        "aggregate": "mean",
        "field": {"repeat": "column"},
        "type": "quantitative",
        "title": "Mean of US and Worldwide Gross"
      },
      "color": {"datum": {"repeat": "column"}, "type": "nominal"}
    },
    "layer": [
      {"name": "foo", "mark": "line"},
      {"name": "bar", "mark": "point"}
    ]
  }
}

the {"repeat": "column"} is not replaced in the normalized spec.

@domoritz domoritz added Bug 🐛 P2 Important Issues that should be fixed soon labels Feb 20, 2023
@ChiaLingWeng
Copy link
Contributor

I think this issue is solved in examples/specs/normalized/repeat_layer_normalized.vl.json

@domoritz
Copy link
Member Author

domoritz commented Jan 30, 2024

It's not fixed in the Vega-Lite compiler, right? Open the Chart in the Vega Editor

Screenshot 2024-01-30 at 11 29 46

@ChiaLingWeng ChiaLingWeng linked a pull request Feb 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 P2 Important Issues that should be fixed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants