Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent predicate output format #4112

Open
domoritz opened this issue Aug 3, 2018 · 3 comments · May be fixed by #9234
Open

Use consistent predicate output format #4112

domoritz opened this issue Aug 3, 2018 · 3 comments · May be fixed by #9234
Labels
Area - Data & Transform Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first) P4 Nice to Have
Milestone
x.x Data & Transf...

Comments

@domoritz
Copy link
Member

domoritz commented Aug 3, 2018

  • Use spaces between operators.

I also propose to use ' instead of " so that we don't have to escape in JSON. Thoughts?
@domoritz domoritz mentioned this issue Aug 3, 2018
Merged
@kanitw
Copy link
Member

kanitw commented Dec 6, 2018

What does this mean?

@kanitw kanitw added the Need Clarification ❔ Needs clarification before we can proceed. label Dec 6, 2018
@domoritz
Copy link
Member Author

domoritz commented Dec 6, 2018

#4109 (comment)

This is about how we generate expressions. We should have spaces around operators everywhere and also use ' instead of ".

@kanitw
Copy link
Member

kanitw commented Dec 21, 2018

Rename this to "Use for consistent predicate output format"? (If I understand your point correctly.)

@domoritz domoritz changed the title Unify predicates Use consistent predicate format Dec 21, 2018
@domoritz domoritz changed the title Use consistent predicate format Use consistent predicate outpit format Dec 21, 2018
@domoritz domoritz changed the title Use consistent predicate outpit format Use consistent predicate output format Dec 21, 2018
@kanitw kanitw added Help wanted 🙏 Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first) P4 Nice to Have and removed Need Clarification ❔ Needs clarification before we can proceed. labels Jun 8, 2019
@kanitw kanitw added this to the x.x Data & Transforms milestone Jun 8, 2019
Ge-limin added a commit to Ge-limin/vega-lite that referenced this issue Jan 29, 2024
@Ge-limin
fix: use consistent predicate output format (vega#4112)
ad7a5cc
@Ge-limin Ge-limin linked a pull request Jan 29, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - Data & Transform Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first) P4 Nice to Have
Projects
None yet
Milestone
x.x Data & Transforms
Development

Successfully merging a pull request may close this issue.

feat: use consistent quotes that don't need to be escaped Ge-limin/vega-lite
2 participants
@kanitw @domoritz