Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exponential moving average to vega-lite #9200

Open
1 task done
julieg18 opened this issue Dec 12, 2023 · 1 comment · May be fixed by #9225
Open
1 task done

Add exponential moving average to vega-lite #9200

julieg18 opened this issue Dec 12, 2023 · 1 comment · May be fixed by #9225
Labels
Enhancement 🎉

Comments

@julieg18
Copy link

Enhancement Description

aggregate_params was added to vega aggregation transforms in vega/vega#3686, allowing exponential moving average. Can we add a way to add these aggregation_params into vega-lite aggregation transforms?

I'm new to vega and vega-lite, but, looking at the code, I think I'd be able to help in adding this into vega-lite.

Checklist

  • I checked for duplicate issues.
@domoritz
Copy link
Member

Absolutely. Please send a pull request. I already added the types in e3a6232 but we need the new aggregate params argument as well.

@julieg18 julieg18 mentioned this issue Dec 14, 2023
Merged
This was referenced Jan 12, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add exponential moving average to vega-lite julieg18/vega-lite
2 participants
@domoritz @julieg18