Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#6708): change domain order for union with #8451

Merged
merged 3 commits into from Oct 10, 2022
Merged

Conversation

ZacharyBys
Copy link
Contributor

@ZacharyBys ZacharyBys commented Oct 5, 2022

fix #6708

Small change to domain order with union with. This was needed to provide custom color mappings when the entire domain isn't known, since the specified fields need to be first to map deterministically to their range values.

Please:

  • Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • Lint and test (Run yarn test).
  • Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • Add new unit tests.
    • Update the documentation under site/docs/ + add examples.

Tips:

📦 Published PR as canary version: 5.5.1--canary.8451.0f10787.0

✨ Test out this PR locally via:

npm install vega-lite@5.5.1--canary.8451.0f10787.0
# or 
yarn add vega-lite@5.5.1--canary.8451.0f10787.0

@ZacharyBys ZacharyBys requested a review from kanitw October 5, 2022 23:27
chore: update examples [CI]

fix test

chore: update examples [CI]

add sort to example
@kanitw kanitw changed the title fix: change domain order for union with fix(#6708): change domain order for union with Oct 10, 2022
@kanitw
Copy link
Member

kanitw commented Oct 10, 2022

@ZacharyBys I've included issue number in the conventional commit message and PR description. Please make sure to include them next time.

@kanitw kanitw merged commit d4591fb into next Oct 10, 2022
@kanitw kanitw deleted the zb/unionwith-order branch October 10, 2022 15:47
kanitw added a commit that referenced this pull request Oct 10, 2022
kanitw added a commit that referenced this pull request Oct 10, 2022
kanitw added a commit that referenced this pull request Oct 10, 2022
)

* Revert "fix(#6708): change domain order for union with (#8451)"

This reverts commit d4591fb.

* fix: Revert "Revert "fix(#6708): change domain order for union with (#8451)""

This reverts commit efc42b5.
@vega-org-bot vega-org-bot mentioned this pull request Oct 10, 2022
6 tasks
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
…vega#8468)

* Revert "fix(vega#6708): change domain order for union with (vega#8451)"

This reverts commit d4591fb.

* fix: Revert "Revert "fix(vega#6708): change domain order for union with (vega#8451)""

This reverts commit efc42b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow fallback color specification for incomplete domain-range mapping
2 participants