New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#6708): change domain order for union with #8451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update examples [CI] fix test chore: update examples [CI] add sort to example
ZacharyBys
force-pushed
the
zb/unionwith-order
branch
from
October 6, 2022 23:25
114a9a6
to
acef6f1
Compare
kanitw
approved these changes
Oct 10, 2022
kanitw
changed the title
fix: change domain order for union with
fix(#6708): change domain order for union with
Oct 10, 2022
@ZacharyBys I've included issue number in the conventional commit message and PR description. Please make sure to include them next time. |
kanitw
added a commit
that referenced
this pull request
Oct 10, 2022
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6708
Small change to domain order with union with. This was needed to provide custom color mappings when the entire domain isn't known, since the specified fields need to be first to map deterministically to their range values.
Please:
Fixes #1
/Fixes part of #1
).yarn test
).site/docs/
+ add examples.Tips:
📦 Published PR as canary version:
5.5.1--canary.8451.0f10787.0
✨ Test out this PR locally via:
npm install vega-lite@5.5.1--canary.8451.0f10787.0 # or yarn add vega-lite@5.5.1--canary.8451.0f10787.0