Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published build artifacts have the wrong version (2.5.0 instead of 2.5.1) #392

Closed
mbostock opened this issue Oct 8, 2022 · 5 comments
Closed
Labels

Comments

@mbostock
Copy link

mbostock commented Oct 8, 2022

Looks like 2.5.1 #390 includes the wrong version 2.5.0 in the published artifacts. Search for “version” here:

https://cdn.jsdelivr.net/npm/vega-datasets@2.5.1/build/vega-datasets.module.js

This results in broken URLs that point to 2.5.0, which is missing data. For example, this:

world = (await import('vega-datasets@2.5.1')).default['world-110m.json'].url

https://cdn.jsdelivr.net/npm/vega-datasets@2.5.0/data/world-110m.json

@domoritz
Copy link
Member

domoritz commented Oct 9, 2022

@hydrosquall I think this is happening because of the auto publishing. Do you have an idea how we can fix this?

This is still a problem in 2.5.2: https://cdn.jsdelivr.net/npm/vega-datasets@2.5.2/build/vega-datasets.module.js

@domoritz domoritz added the bug label Oct 9, 2022
@domoritz
Copy link
Member

domoritz commented Oct 9, 2022

Also, https://cdn.jsdelivr.net/npm/vega-datasets@2.5.3 has version 2.5.2 in it.

@domoritz
Copy link
Member

domoritz commented Oct 9, 2022

Vega-Lite is also broken: https://cdn.jsdelivr.net/npm/vega-lite@5.5.0/build/vega-lite.js has version 5.2.0.

@hydrosquall
Copy link
Member

hydrosquall commented Oct 12, 2022 via email

@domoritz
Copy link
Member

Switched to release-it. The version is correct as of 2.5.4: https://cdn.jsdelivr.net/npm/vega-datasets@2.5.4/build/vega-datasets.module.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants