New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Published build artifacts have the wrong version (2.5.0 instead of 2.5.1) #392
Comments
@hydrosquall I think this is happening because of the auto publishing. Do you have an idea how we can fix this? This is still a problem in 2.5.2: https://cdn.jsdelivr.net/npm/vega-datasets@2.5.2/build/vega-datasets.module.js |
Also, https://cdn.jsdelivr.net/npm/vega-datasets@2.5.3 has version 2.5.2 in it. |
Vega-Lite is also broken: https://cdn.jsdelivr.net/npm/vega-lite@5.5.0/build/vega-lite.js has version 5.2.0. |
Yes, this is the same issue affecting vega-lite reported here
vega/vega-lite#8370
Unfortunately all 3 repos are affected by the same bug:
intuit/auto#2047
It looks like the version is bumped *after* publishing, and the bumps from
the stable branch don’t propagate back to the next branch.
I haven’t gotten a clear answer on what to do about this from the auto
end. Haven’t been working on build systems recently but am debating
between making a plugin to fix it, or switching to a more actively
maintained project (the two original maintainers of auto no longer work for
intuit, which may have made it harder to support this library)
…On Sun, Oct 9, 2022 at 10:24 AM Dominik Moritz ***@***.***> wrote:
Vega-Lite is also broken:
***@***.***/build/vega-lite.js has
version 5.2.0.
—
Reply to this email directly, view it on GitHub
<#392 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE2MM4LDFUDVZ2NBEPWP2DWCLISXANCNFSM6AAAAAARAKW3VI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Switched to release-it. The version is correct as of 2.5.4: https://cdn.jsdelivr.net/npm/vega-datasets@2.5.4/build/vega-datasets.module.js. |
Looks like 2.5.1 #390 includes the wrong version 2.5.0 in the published artifacts. Search for “version” here:
https://cdn.jsdelivr.net/npm/vega-datasets@2.5.1/build/vega-datasets.module.js
This results in broken URLs that point to 2.5.0, which is missing data. For example, this:
https://cdn.jsdelivr.net/npm/vega-datasets@2.5.0/data/world-110m.json
The text was updated successfully, but these errors were encountered: