build/vega-datasets.min.js is now an iife, breaking require

[mbostock]

I noticed that #388 changed build/vega-datasets.min.js to be an IIFE:

vega-datasets/rollup.config.js

Lines 40 to 46 in b2c5de0

	{
	file: "build/vega-datasets.min.js",
	format: "iife",
	sourcemap: true,
	name: "vegaDatasets",
	plugins: [terser()],
	},

Whereas build/vega-datasets.js is still a UMD:

vega-datasets/rollup.config.js

Lines 34 to 39 in b2c5de0

	{
	file: "build/vega-datasets.js",
	format: "umd",
	sourcemap: true,
	name: "vegaDatasets",
	},

The problem is that require("vega-datasets") on Observable will use your unpkg/jsdelivr entry point which points to the IIFE, and thus errors:

vega-datasets/package.json

Lines 8 to 9 in b2c5de0

	"unpkg": "build/vega-datasets.min.js",
	"jsdelivr": "build/vega-datasets.min.js",

You can see it breaking here:

https://observablehq.com/@vega/vega-lite-input-binding

If you want to drop UMD support, we could fix that notebook (and presumably others) by using ES import instead of require:

world = (await import('vega-datasets')).default['world-110m.json'].url

But if you are supporting IIFE, maybe it’s worth continuing to support UMD for backwards compatibility?

[domoritz]

Thanks for the issue. I'll switch back to umd.

[github-actions]

🚀 Issue was released in v2.5.2-next.0 🚀

[mbostock]

Thanks for working on these issues Dominik!