Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding built-in formatters #597

Merged
merged 4 commits into from
Dec 14, 2020

Conversation

fwal
Copy link
Contributor

@fwal fwal commented Dec 14, 2020

Allow overriding built-in formatters by running the augmentor first.
Also a line of code that was missing from the readme.

Fixes #596

@domoritz domoritz self-requested a review December 14, 2020 20:40
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix. Can you correct the lining errors?

@fwal
Copy link
Contributor Author

fwal commented Dec 14, 2020

Yes, fixed now.

@domoritz domoritz merged commit 57c3d2c into vega:master Dec 14, 2020
@fwal fwal deleted the fwal/override-formatters branch December 15, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom formatters not working as intended?
2 participants