Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Definition Not Created When Properties Are Nullable #1420

Merged

Conversation

ThatOneAwkwardGuy
Copy link
Contributor

@ThatOneAwkwardGuy ThatOneAwkwardGuy commented Sep 24, 2022

fixes issue #1419

When using the @nullable annotation, the type of a definition may go from:

type: "string"

to:

type: ["string", "null"]

The check for removing unreachable definitions only assumed the attribute type was a string and not an array of strings.

Version

Published prerelease version: v1.1.2-next.0

Changelog

馃帀 This release contains work from a new contributor! 馃帀

Thank you, Moyo George (@ThatOneAwkwardGuy), for all your work!

馃悰 Bug Fix

Authors: 1

@domoritz domoritz merged commit 278e791 into vega:next Sep 25, 2022
@domoritz
Copy link
Member

Thank you

@ThatOneAwkwardGuy ThatOneAwkwardGuy deleted the annotation-nullable-definition branch September 25, 2022 02:42
@github-actions
Copy link

馃殌 PR was released in v1.1.2 馃殌

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants