Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support intrinsic string manipulation types #1173

Merged
merged 2 commits into from Mar 21, 2022

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Mar 21, 2022

@@ -14,6 +14,10 @@ indent_size = 4
indent_style = space
indent_size = 4

[test/**/schema.json]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this rule because the editor kept changing the indent of schema.json files to 4.

Copy link
Member

@domoritz domoritz Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably remove this file since we enforce style through prettier already. The editorconfig doesn't add much benefit anymore, I think.

@@ -4,6 +4,33 @@
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
//
// Helps with debugging parsing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This launch configuration made it much easier for me to debug my changes. I would just open the main.ts file I wanted to parse and run the debugger.

I leave it up to you if you want to keep it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!

@Jason3S Jason3S changed the title feat: support intrinsic type manipulation functions feat: support intrinsic string manipulation types Mar 21, 2022
@@ -0,0 +1,7 @@
import { LogicError } from "../Error/LogicError";

export default function assert(value: unknown, message: string): asserts value {
Copy link
Contributor Author

@Jason3S Jason3S Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this method to make test coverage easier. It wasn't possible to make a main.ts sample to cause the assumptions about the compiler to trigger. So, I took this route to I can assert that the assumptions about the compiler are still true while being able to catch future incompatibilities.

@domoritz domoritz merged commit 8f2dc15 into vega:next Mar 21, 2022
@domoritz
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants