Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: oTable.fnSettings is not a function #680

Open
VictorioBerra opened this issue Mar 13, 2024 · 11 comments
Open

TypeError: oTable.fnSettings is not a function #680

VictorioBerra opened this issue Mar 13, 2024 · 11 comments

Comments

@VictorioBerra
Copy link

Does YADCF support DataTables 2.0? fnSettings get dropped?

@vedmack
Copy link
Owner

vedmack commented Mar 14, 2024

haven't checked compatibility with the 2.0, please share a working test page (jsfiddle / etc) so I check it out

@VictorioBerra
Copy link
Author

@vedmack https://jsfiddle.net/425gmakb/1/

Your CSS is in the "CSS" tab, your JS is in the "JS" tab. At the very bottom is the sample code from your "DOM source" example.

@VictorioBerra
Copy link
Author

@vedmack Any thoughts on this?

The error is being thrown here: https://github.com/vedmack/yadcf/blob/master/src/jquery.dataTables.yadcf.js#L5269

Should this be this.api().settings().tables()[0].sTableId?

fnSettings is being accessed in a LOT of places. Does this all need to be changed to access settings via the public API somehow now?

@VictorioBerra
Copy link
Author

Here is a self-contained index.html, jsfiddle just chokes out when I try and work in it with all that code. Hope this helps.

https://gist.github.com/VictorioBerra/6b2fd02957ad430a5ce91f95087b4b4c

@vedmack
Copy link
Owner

vedmack commented Apr 6, 2024

Hi @VictorioBerra, I will check this out

@VictorioBerra
Copy link
Author

@vedmack Any luck?

@louking
Copy link
Contributor

louking commented Apr 29, 2024

FWIW, all the legacy API has been removed (functions starting with fn). See https://www.datatables.net/blog/2024/datatables-2#Removed and https://www.datatables.net/upgrade/2#Removed for details.

vedmack added a commit that referenced this issue May 17, 2024
@vedmack
Copy link
Owner

vedmack commented May 17, 2024

@VictorioBerra @louking I just pushed the 2.0.1.beta.1 although I did a lot of API adoptions to the new DT 2, there is still a lot of work to be done, so it might take some time, feel free to check it out and provide feedback
https://github.com/vedmack/yadcf/blob/master/2.0/jquery.dataTables.yadcf-2.0.js
I did noticed that there seems to be some issue with jquery UI filter plugins that I need to resolve

@VictorioBerra
Copy link
Author

@vedmack thank you!! I am looking forward to it!

vedmack added a commit that referenced this issue May 19, 2024
@vedmack
Copy link
Owner

vedmack commented May 19, 2024

@VictorioBerra check out yadcf 2.0.1.beta.4 on https://jsfiddle.net/vedmack/8bur71tk/ test page
feel free to provide additional test cases
note that you should use the yadcf.init to init the filters

@vedmack
Copy link
Owner

vedmack commented May 22, 2024

new showcase page https://yadcf.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants