Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Idea]: Support for 1.4 manifests #82

Closed
sitiom opened this issue Jan 26, 2023 · 5 comments · Fixed by #93
Closed

[Feature/Idea]: Support for 1.4 manifests #82

sitiom opened this issue Jan 26, 2023 · 5 comments · Fixed by #93
Labels
feat New feature request

Comments

@sitiom
Copy link
Contributor

sitiom commented Jan 26, 2023

What would you like to see changed/added?

Support for 1.4 manifests. Also, updating the RelativeFilePath should be supported in cases where the executable is inside a versioned directory. For example:

- RelativeFilePath: bat-v0.22.1-x86_64-pc-windows-msvc\bat.exe
@sitiom sitiom added the feat New feature request label Jan 26, 2023
@vedantmgoyal9
Copy link
Owner

vedantmgoyal9 commented Jan 26, 2023

bat-v<0.22.1>-x86_64-pc-windows-msvc: is 0.22.1 package version? It can be difficult to find otherwise.

@sitiom
Copy link
Contributor Author

sitiom commented Jan 26, 2023

Yes, or maybe just use regex.

@russellbanks
Copy link
Contributor

The next update of WinGet Releaser will use Komac which supports 1.4.0 manifests. I'm just working on updating the RelativeFilePath with regex.

@sitiom
Copy link
Contributor Author

sitiom commented Feb 12, 2023

So, how do I update the RelativeFilePath in the new version?

@russellbanks
Copy link
Contributor

russellbanks commented Mar 5, 2023

So, how do I update the RelativeFilePath in the new version?

The RelativeFilePath should automatically update. For example:

RelativeFilePath: bat-v0.22.1-x86_64-pc-windows-msvc\bat.exe

Will become (if the new version is 0.23.0, for example):

RelativeFilePath: bat-v0.23.0-x86_64-pc-windows-msvc\bat.exe

It does this by getting all the previous versons on winget and replacing the part of the string that contains one of those versions with the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants