Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added notes about the usage of the action #54

Merged
merged 1 commit into from
Nov 23, 2022
Merged

docs: added notes about the usage of the action #54

merged 1 commit into from
Nov 23, 2022

Conversation

gerardog
Copy link
Contributor

@gerardog gerardog commented Nov 8, 2022

@gerardog
Copy link
Contributor Author

gerardog commented Nov 9, 2022

We can add a Prerequisites section if you want.

@vedantmgoyal9
Copy link
Owner

Hi, my house is undergoing renovation, so I'll be able to review & merge after next few weeks. My PC is currently disassembled.

@gerardog
Copy link
Contributor Author

gerardog commented Nov 10, 2022 •
edited

Great.
What may work for you is to go to this PR files tab and read each paragraph, click on the + sign and leave notes and comments.

image

Can be done from the web.

@vedantmgoyal9 vedantmgoyal9 removed their request for review November 23, 2022 08:16
@vedantmgoyal9 vedantmgoyal9 changed the title docs: Added clarifications docs: added notes about the usage of the action Nov 23, 2022
@vedantmgoyal9 vedantmgoyal9 added the documentation Improvements or additions to documentation label Nov 23, 2022
@vedantmgoyal9 vedantmgoyal9 merged commit ef4cc7e into vedantmgoyal9:main Nov 23, 2022
@vedantmgoyal9 vedantmgoyal9 linked an issue Nov 23, 2022 that may be closed by this pull request
docs: mention that action does not works for draft releases #49
Closed
@vedantmgoyal9
Copy link
Owner

@allcontributors please add @gerardog for docs

@allcontributors allcontributors bot mentioned this pull request Nov 23, 2022
Merged
@allcontributors
Copy link
Contributor

@vedantmgoyal2009

I've put up a pull request to add @gerardog! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: mention that action does not works for draft releases
2 participants
@gerardog @vedantmgoyal9