Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Idea]: Add maximum package versions functionality #3

Closed
russellbanks opened this issue Jul 28, 2022 · 1 comment · Fixed by #93
Closed

[Feature/Idea]: Add maximum package versions functionality #3

russellbanks opened this issue Jul 28, 2022 · 1 comment · Fixed by #93
Labels
feat New feature request

Comments

@russellbanks
Copy link
Contributor

russellbanks commented Jul 28, 2022

What would you like to see changed/added?

This feature would be like delete-previous-version, except it would delete the oldest version once the amount of versions within a package have reached a maximum number.

For example, you have package-x, with maximum versions set to 5:

1.0.0
1.1.0
1.2.0
1.3.0
1.4.0

When the next version, say 1.5.0, is released, winget-releaser would then delete 1.0.0 in that same pull request.

This would be most useful in packages that push a lot of updates but want to keep their version history clean, as it is uncommon for users to need versions that old.

This links to microsoft/winget-pkgs#66854 (reply in thread):

Quick answer; Feel free to add old versions (major and/or up to the 10 latest versions)

@russellbanks russellbanks added the feat New feature request label Jul 28, 2022
@vedantmgoyal9
Copy link
Owner

vedantmgoyal9 commented Jul 29, 2022

This will be a great addition, but I won't like to implement it now since the YamlCreate script is being re-written to perform operations on manifests more easily using parameters. I guess it will be completed in the next few months, so expect this in the action by December or maybe earlier ;)

@vedantmgoyal9 vedantmgoyal9 removed their assignment Feb 10, 2023
@vedantmgoyal9 vedantmgoyal9 linked a pull request Feb 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants