Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off of chrono to time #9675

Closed
jszwedko opened this issue Oct 18, 2021 · 6 comments
Closed

Migrate off of chrono to time #9675

jszwedko opened this issue Oct 18, 2021 · 6 comments
Labels
domain: deps Anything related to Vector's dependencies type: task Generic non-code related tasks

Comments

@jszwedko
Copy link
Member

chrono is lightly maintained these das (no release in a year nor responsive to issues, including security issues) and the time crate reportedly implements much of what chrono is used for.

We should:

  • Remove our own dependency on chrono
    • We should maintain support for the strftime specifiers for parsing and formatting. The time crate [does not support this] so we will need to implement it ourselves.
  • Open issues on all dependencies that depend on chrono to see if they are open to migrating. Ideally we could open PRs on the dependencies to help expedite the process.

This would resolve RUSTSEC-2020-0071.
@jszwedko jszwedko added type: task Generic non-code related tasks domain: deps Anything related to Vector's dependencies labels Oct 18, 2021
@jszwedko
Copy link
Member Author

We might be able to translate strftime specifiers into their specifiers https://github.com/time-rs/format-converter.

jszwedko added a commit that referenced this issue Oct 18, 2021
@jszwedko
chore(deps): Patch dependencies to remove dependency on time v0.1
ddaf2fe 
Which is vulnerable to `RUSTSEC-2020-0071`.

`chrono` seems to be no longer maintained so
#9675 will be the real
solution for that.

The other dependencies should be able to be unpatched once they have
a release removing the dependency.

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
This was referenced Oct 18, 2021
Merged
Closed
@bruceg
Copy link
Member

bruceg commented Oct 19, 2021

Does the time crate have support for timezones, like is present in chrono-tz? We use this for handling local times.

@jszwedko
Copy link
Member Author

Yeah, that's a good point. It looks like not yet: time-rs/time#193

jszwedko added a commit that referenced this issue Dec 8, 2021
@jszwedko
chore(deps): Patch dependencies to remove dependency on time v0.1 (#…
7c31189 
…9678)

* chore(deps): Patch dependencies to remove dependency on `time` v0.1

Which is vulnerable to `RUSTSEC-2020-0071`.

`chrono` seems to be no longer maintained so
#9675 will be the real
solution for that.

The other dependencies should be able to be unpatched once they have
a release removing the dependency.

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
@spencergilbert
Copy link
Contributor

Does the time crate have support for timezones, like is present in chrono-tz? We use this for handling local times.

Possible option: https://github.com/Yuri6037/time-tz

@spencergilbert
Copy link
Contributor

chrono appears to be getting picked back up

@jszwedko
Copy link
Member Author

Closing this since chrono seems to have more active maintenance these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: deps Anything related to Vector's dependencies type: task Generic non-code related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jszwedko @bruceg @spencergilbert