Skip to content

SuppressNotice push rule does not prevent the total notification count from increasing in encrypted rooms #24448

Closed
matrix-org/matrix-js-sdk
#3130
@Half-Shot

Description

@Half-Shot
Member

Steps to reproduce

  1. Create an encrypted room between two clients you control.
  2. Ensure the receiver has Messages sent by bot turned to the off position in the Notification settings.
  3. Ensure the reciever does NOT have the room focused.
  4. On the sending client, manually send a message with a msgtype of m.notice.
  5. On the receiving client, notice that the room notification count increases.

Outcome

What did you expect?

As with unencrypted rooms, the room notification count should not increase.

What happened instead?

The counter increases.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

Element version: 1.11.20 Olm version: 3.2.12

Homeserver

Synapse / half-shot.uk

Will you send logs?

No

Activity

Half-Shot

Half-Shot commented on Feb 6, 2023

@Half-Shot
MemberAuthor

Debugging notes

So far in my investigation, I can see that matrix-js-sdk correctly matches a PushRule against the encrypted event so getPushActionsForEvent will return a object with {"notify": false}

However, the subsequent logic block assumes that if the event does not highlight and the highlight count hasn't changed, no more adjustments need to be made on the client.

added
S-MinorImpairs non-critical functionality or suitable workarounds exist
O-OccasionalAffects or can be seen by some users regularly or most users rarely
on Feb 13, 2023
added a commit that references this issue on Mar 15, 2023
0c0854b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-NotificationsO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorImpairs non-critical functionality or suitable workarounds existT-Defect

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @dbkr@Half-Shot

      Issue actions

        SuppressNotice push rule does not prevent the total notification count from increasing in encrypted rooms · Issue #24448 · element-hq/element-web