Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-comment updates the same comment in reusable workflows #29

Open
js-beaulieu opened this issue Oct 7, 2022 · 1 comment
Open

Comments

@js-beaulieu
Copy link

I'm trying to use this in a monorepo, where we have a reusable workflow that does the whole checkout/npm ci/npm run <command> etc. shenanigans.

Unfortunately, the update-comment option doesn't seem to play well with reusable workflows. Looking at the code, it's looking for a comment containing <!-- Code Coverage Comment: <workflow name> -->. I feel like it should probably use the optional name input if provided rather than the workflow name, as this means different test suites end up overwriting each other.

nevercast added a commit to nevercast/jest-lcov-reporter that referenced this issue May 24, 2024
Multiple coverage reports in the same workflow do not trample each other when updating.
@nevercast
Copy link

Thanks for mentioning this, @js-beaulieu - it made it very quick to find.

nevercast added a commit to nevercast/jest-lcov-reporter that referenced this issue May 24, 2024
Multiple coverage reports in the same workflow do not trample each other when updating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants