Update Aruba #780
Merged
Update Aruba #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he difference between 0.8.8 and 0.9 is miniscule in terms of code but it is much easier to then use 0.9.10 to compile Alternatively, we could just set this to be >= 0.8.8 < 1.0??
The implementation of check_file_content was changed to only do an exact match when the second argument is a string, and subsequently the method was deprecated. This fixes both problems in one go.
olleolleolle
approved these changes
Dec 9, 2019
|
I am going to squash-and-merge this to master now, and I'd like to thank @mvz for painstakingly doing this work. |
|
Hm, maybe we should check the build failure first? |
|
(And I hate squash merging 🤷♂️) |
It's the only available allowed PR merge option configured in this repository. |
|
OK, trying again, now |
|
All green! 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a based on #772 and fixes the remaining deprecation warnings and test failures.