Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build due to Hashdiff deprecation warning #758

Merged

Conversation

mattbrictson
Copy link
Contributor

webmock uses the hashdiff gem, which recently introduced a deprecation warning regarding the spelling of the Hashdiff constant.

The HashDiff constant used by this gem conflicts with another gem of a similar name.
As of version 1.0 the HashDiff constant will be completely removed and replaced by Hashdiff.

This warning in the output causes one of the vcr cucumber tests to fail. This is why the master branch currently has a failing Travis build.

The fix is to update to the latest version of the hashdiff gem, which is currently in beta, as suggested here: bblimke/webmock#823 (comment)

webmock uses the hashdiff gem, which recently introduced a deprecation
warning regarding the spelling of the `Hashdiff` constant.

```
The HashDiff constant used by this gem conflicts with another gem of a similar name.
As of version 1.0 the HashDiff constant will be completely removed and replaced by Hashdiff.
```

This warning in the output causes one of the vcr cucumber tests to fail.

The fix is to update to the latest version of the hashdiff gem, which is
currently in beta.
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a good investigation, and a clear fix, well-documented.

Let's get this merged! 🚢

@olleolleolle olleolleolle merged commit 47fe1fd into vcr:master Jun 20, 2019
@mattbrictson mattbrictson deleted the fix-broken-master-build-due-to-hashdiff branch June 20, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants