Include body.class feedback for non-String body error #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A VCR::Request object performs this following initialization check:
The error is raised for a non-String body, so it's helpful for the error message to return the actual
body.class
-- butbody.inspect
isn't a robust way to provide that, since some but not all objects include the class in their.inspect
output. So this PR explicitly includesbody.class
output.It also parenthetically mentions "(non-String)" after "invalid", to try to convey the issue is about the class check and not anything with the content of the body, itself.
Resolves #748