Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies madness #150

Closed
radekmie opened this issue Dec 18, 2016 · 0 comments
Closed

Optional dependencies madness #150

radekmie opened this issue Dec 18, 2016 · 0 comments
Assignees
Labels
Type: Bug Bug reports and their fixes

Comments

@radekmie
Copy link
Contributor

radekmie commented Dec 18, 2016

This came out in #148. Thanks, @saeedjalali1.

Back in v1.1.3, I've did this change:

-SimpleSchema = require('simpl-schema').default;
+SimpleSchema = (0, require)('simpl-schema').default;

To get rid of Meteor warning:

Unable to resolve some modules:

  "simpl-schema" in .../uniforms/lib/bridges/SimpleSchema2Bridge.js (web.browser)

If you notice problems related to these missing modules, consider running:

  meteor npm install --save simpl-schema

As I found out today, it caused problems with using uniforms in Webpack:

Warning in ./~/uniforms/lib/bridges/SimpleSchema2Bridge.js
Module not found: 'simpl-schema' in .../uniforms/lib/bridges

To fix it, I will revert this change. This will cause both Meteor and Webpack complain about it with warnings with very long stack traces, but everything will work in both environments. I'll keep as it is for few days, maybe new ideas will come.

I've did some research and it's not possible to silent this warning in either Meteor or Webpack. If you know a way on how to hack it - let me know.

In the future, schema packages will be separated, so this won't be a problem anymore.

This is just an informational issue to track this change.

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Dec 18, 2016
@radekmie radekmie self-assigned this Dec 18, 2016
@Monteth Monteth added this to Closed in Open Source (migrated) Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

No branches or pull requests

1 participant