New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create nexus lazily to avoid an error when properties aren't set #405

Merged

gabrielittner merged 1 commit into vanniktech:master from eygraber:lazy-nexus

Sep 5, 2022

Contributor

eygraber commented Sep 5, 2022

Fixes #381 (comment)

The other way to do it would be to make Nexus (and all subsequent types) take Provider<String> instead of String


          Create nexus lazily to avoid an error when properties aren't set

ecdd3b1

vanniktech approved these changes

View reviewed changes

vanniktech requested a review from gabrielittner

September 5, 2022 07:09

gabrielittner approved these changes

View reviewed changes

Collaborator

gabrielittner left a comment

I wonder why I didn't run into the issue while testing. Thanks for trying out the snapshots and for submitting the fix

gabrielittner merged commit 5e48420 into vanniktech:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment