workaround issues with the signing setup #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
force-pushed
the
signing-issues
branch
from
add6142
to
0ed6c1e
Compare
gabrielittner
commented
Sep 4, 2022
Comment on lines
+74
to
+77
| project.tasks.withType(PublishToMavenRepository::class.java).configureEach { publishTask -> | ||
| if (publishTask.name.endsWith("ToMavenCentralRepository")) { | ||
| publishTask.dependsOn(createRepository) |
There was a problem hiding this comment.
Found out that PublishToMavenRepository is in the public API so we can use it here as a filter which makes it nicer than afterEvaluate
gabrielittner
force-pushed
the
signing-issues
branch
from
0ed6c1e
to
c4cd3bc
Compare
gabrielittner
commented
Sep 4, 2022
Comment on lines
+125
to
+133
| // TODO: replace with the following line after https://github.com/gradle/gradle/issues/21857 is fixed | ||
| // project.gradleSigning.sign(project.gradlePublishing.publications) | ||
| project.gradlePublishing.publications.withType(MavenPublication::class.java).all { publication -> | ||
| val task = project.tasks.findByName("sign${publication.name.capitalize()}Publication") | ||
| if (task == null) { | ||
| project.gradleSigning.sign(publication) | ||
| } | ||
| } |
There was a problem hiding this comment.
Only call sign on a publication if there is no signing task for it yet which fixes the issue when other plugins already called it.
gabrielittner
force-pushed
the
signing-issues
branch
from
c4cd3bc
to
eb8e98e
Compare
gabrielittner
commented
Sep 4, 2022
Comment on lines
+135
to
+138
| // TODO: remove after https://youtrack.jetbrains.com/issue/KT-46466 is fixed | ||
| project.tasks.withType(AbstractPublishToMaven::class.java) { publishTask -> | ||
| publishTask.dependsOn(project.tasks.withType(Sign::class.java)) | ||
| } |
There was a problem hiding this comment.
Workaround taken from the linked ticket
vanniktech
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #387
closes #338