fix legacy Android setup in mpp projects #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
May 28, 2022
|
I've added a general MPP + Android integration test in #351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes publishing Kotlin Multiplatform projects that apply an Android plugin < 7.1.2. In 0.18.0 and earlier Android publishing was configured in the same when as all other plugins and had lower priority than Kotlin MPP (see here). The changes for the new Android API moved it out of that when. The code path for the new API had a check to not do anything for multiplatform, but the code path for older AGP versions was missing this which resulted in the Kotlin MPP publication being overridden. This restores the 0.18.0 behavior of not calling the Android APIs in a mpp project.
I will separately look at the issue of MPP + AGP >= 7.1.2 (#333)