add support for LICENSE properties in addition to LICENCE #272
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Jun 20, 2021
ajalt
pushed a commit
to ajalt/mordant
that referenced
this pull request
Jan 16, 2025
Hello, I am using this library in one of the projects and during the license compliance check I noticed that its POM looks a bit strange - it has 2 **license** blocks inside the [licenses](https://repo1.maven.org/maven2/com/github/ajalt/mordant/mordant-jvm-jna-jvm/3.0.1/mordant-jvm-jna-jvm-3.0.1.pom) block. <details><summary>POM part</summary> <p> ```xml <licenses> <license> <name>Apache-2.0</name> <url>https://www.apache.org/licenses/LICENSE-2.0</url> </license> <license> <distribution>repo</distribution> </license> </licenses> ``` </p> </details> Right now there are two versions of license properties are used (LICEN**S**E and LICEN**C**E) in gradle.properties. POM_LICENSE_DIST is added as a separate license because of the following change in gradle-maven-publish-plugin: vanniktech/gradle-maven-publish-plugin#272. I renamed all the options to LICEN**S**E to match the naming in Gradle API and the license itself. Please, let me know If I have missed anything in the PR (update the changelog for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #252
I've changed the readme you LICENSE because that matches the spelling Gradle uses in their API.