From be150320a17b7708af83b500bd9117a088483569 Mon Sep 17 00:00:00 2001 From: byene0923 Date: Fri, 28 Oct 2022 01:21:46 +0800 Subject: [PATCH] fix: 1. the length of trailer key should > 0 2. fix http_test words typo --- header.go | 2 +- http_test.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/header.go b/header.go index fd3defdcd9..89499a36db 100644 --- a/header.go +++ b/header.go @@ -2520,8 +2520,8 @@ func (h *ResponseHeader) parseTrailer(buf []byte) (int, error) { err = fmt.Errorf("forbidden trailer key %q", s.key) continue } + h.h = appendArgBytes(h.h, s.key, s.value, argsHasValue) } - h.h = appendArgBytes(h.h, s.key, s.value, argsHasValue) } if s.err != nil { return 0, s.err diff --git a/http_test.go b/http_test.go index 58bc8cb4ff..09902656e6 100644 --- a/http_test.go +++ b/http_test.go @@ -1641,10 +1641,10 @@ func TestRequestReadLimitBody(t *testing.T) { } func testResponseReadLimitBodyError(t *testing.T, s string, maxBodySize int, expectedErr error) { - var req Response + var resp Response r := bytes.NewBufferString(s) br := bufio.NewReader(r) - err := req.ReadLimitBody(br, maxBodySize) + err := resp.ReadLimitBody(br, maxBodySize) if err == nil { t.Fatalf("expecting error. s=%q, maxBodySize=%d", s, maxBodySize) } @@ -1654,10 +1654,10 @@ func testResponseReadLimitBodyError(t *testing.T, s string, maxBodySize int, exp } func testResponseReadLimitBodySuccess(t *testing.T, s string, maxBodySize int) { - var req Response + var resp Response r := bytes.NewBufferString(s) br := bufio.NewReader(r) - if err := req.ReadLimitBody(br, maxBodySize); err != nil { + if err := resp.ReadLimitBody(br, maxBodySize); err != nil { t.Fatalf("unexpected error: %v. s=%q, maxBodySize=%d", err, s, maxBodySize) } }