Handle request URI containing query parameters but no path. #1661
Conversation
header.go
Outdated
| @@ -681,6 +681,8 @@ func (h *RequestHeader) RequestURI() []byte { | |||
| requestURI := h.requestURI | |||
| if len(requestURI) == 0 { | |||
| requestURI = strSlash | |||
| } else if requestURI[0] == '?' { | |||
| requestURI = append(strSlash, requestURI...) | |||
There was a problem hiding this comment.
This would cause an allocation, which we always try to avoid in fasthttp. I'm wondering if it isn't better to add the / here when needed:
Line 2815 in 699af40
There was a problem hiding this comment.
Ah, great point. I've updated the change to modify the request URI when set through either the SetRequestURI or SetRequestURIBytes functions.
There was a problem hiding this comment.
I'm sorry but I don't think SetRequestURI and SetRequestURIBytes need to be fixed. Users have control over these and can append the / themselves.
Your issue was with clients sending a GET ?foo=bar request. In that case this is not going to fix it. You need to fix it here in the request parsing code:
Line 2815 in 699af40
Ah, I see. I'm only using the FastHTTP client, not the FastHTTP server. My expectation was that the FastHTTP client would handle URLs using this format since that's the behavior of the built-in |
|
I'm a little bit afraid to make backwards breaking changes like this. I'll leave this pull request open for now and see if anyone else runs into this. |
Fixes #1659
When returning a request URI, check whether it begins with a query (i.e.
?), in which case we should apply a default path of/). This is required to conform to the HTTP 1.1 specification.