feat: add PeekKeys and PeekTrailerKeys #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Oct 23, 2022
header.go
Outdated
| @@ -43,6 +43,7 @@ type ResponseHeader struct { | |||
| contentEncoding []byte | |||
| server []byte | |||
| mulHeader [][]byte | |||
| keys [][]byte | |||
There was a problem hiding this comment.
You can re-use mulHeader for this. But I do think we need to improve the warning for these and the PeekAll functions to make it clear that any further calls to Peek* functions will also change the return values.
There was a problem hiding this comment.
I have modified the code and added the relevant code comments
li-jin-gou
force-pushed
the
feat/peek_keys
branch
from
83c78af
to
276d8cd
Compare
li-jin-gou
force-pushed
the
feat/peek_keys
branch
from
276d8cd
to
a8f79d7
Compare
erikdubbelboer
requested changes
Oct 29, 2022
erikdubbelboer
approved these changes
Oct 29, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr for #1400