optimize: adjust the behavior of PeekAll based on VisitAll #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jin-gou
commented
Oct 21, 2022
| @@ -1827,7 +1833,6 @@ func (h *RequestHeader) peekAll(key []byte) [][]byte { | |||
| case HeaderCookie: | |||
| if h.cookiesCollected { | |||
| h.mulHeader = append(h.mulHeader, appendRequestCookieBytes(nil, h.cookies)) | |||
| return [][]byte{appendRequestCookieBytes(nil, h.cookies)} | |||
There was a problem hiding this comment.
I apologize for a problem here that I didn't find before.
| @@ -1853,11 +1858,17 @@ func (h *ResponseHeader) peekAll(key []byte) [][]byte { | |||
| h.mulHeader = h.mulHeader[:0] | |||
| switch string(key) { | |||
| case HeaderContentType: | |||
| h.mulHeader = append(h.mulHeader, h.ContentType()) | |||
| if contentType := h.ContentType(); len(contentType) > 0 { | |||
There was a problem hiding this comment.
Referring to VisitAll, I found that when using PeekAll, if the field is empty, he returns [][]byte{ '' } instead of [][]byte{} to the point that I modified it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to #1394 (comment)