make RequestCtx's userdata accept keys that are of type: interface{} #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Oct 5, 2022
server.go
Outdated
| @@ -702,7 +702,7 @@ func (ctx *RequestCtx) UserValueBytes(key []byte) interface{} { | |||
| // | |||
| // visitor must not retain references to key and value after returning. | |||
| // Make key and/or value copies if you need storing them after returning. | |||
| func (ctx *RequestCtx) VisitUserValues(visitor func([]byte, interface{})) { | |||
| func (ctx *RequestCtx) VisitUserValues(visitor func(interface{}, interface{})) { | |||
There was a problem hiding this comment.
This is a backwards incompatible change that I don't want to make. Maybe this should only visit the values that have a []byte key and another method should be added for all values?
There was a problem hiding this comment.
@erikdubbelboer Change made.
|
Thanks! |
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1385